The module I'm submitting now is something I'm using for a client project I helped build. It will be called In Person Payment Method, or "uc_in_person". The client wanted an in-person payment method and payment tracking system. It is basically a clone of the "Check" payment method for Ubercart, with configurable titles and descriptions, and re-worked text that's changed from "receive check" to "process payment". It creates a table "uc_payment_in_person" to keep track of payments made using the payment method. Right now it is in a git repo, and drush make is loading it as part of a site building script. You can see the code at https://github.com/jessehs/In-Person-Payments.
I want to be a maintainer because I know I have and will develop code that others could use, and I use the code that others have created every day. I want to be a contributing member of the community. As a side-note, OpenSourcery happens to host the monthly Portland Drupal meetings, and I've been to several since I was hired, including the local D7 release party. I have a new found appreciation for being a part of a Drupal community.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | uc_in_person.tar_.gz | 14.88 KB | jessehs |
Comments
Comment #1
jessehsComment #2
avpadernoHello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.
I will report here a little checklist:
As per requirements, the motivation message needs to contain a comparison with the existing solutions too.
Comment #3
jessehsI ran it through the coder module and fixed one line (else statement was on the same line as the previous closing bracket).
I also added a README file. You can see the latest version at the github repo I mentioned before.
I made the module because I couldn't find any other payment method that would work out of the box. I could have used the check payment, but the client specifically asked for an in person cash payment method.
Comment #4
avpadernoPlease attach the updated archive here.
The motivation message needs to be expanded as per my previous comment. You cannot edit the OP that has been created for you; you need to write the new motivation message in a comment.
Comment #5
avpadernoPlease read all the following and the links provided as this is very important information about your CVS Application.
Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:Migrating from CVS Applications to (Git) Full Project Applications.
Comment #6
jessehsI've updated the project with two or three code fixes that follow drupal.org's coding standards. Mostly having a space before and after the "." in a concatenation.
The project is now a drupal.org git sandbox: http://drupal.org/sandbox/jessehs/1089542
In response to comment #4, I don't think that there is any other solution out there that can be customized to say exactly how the payment should work without creating a module to alter the message, or hacking the uc_check module.
Comment #7
jessehsChanging to Drupal.org Project applications
Comment #8
dstolLooks good!
Comment #9
zzolo commentedThis module looks good to go. Review was done at DrupalCon Chicago Code Review Sprint. I talked with @dstol in person about how he did his review and that things do follow standards.
Please read the following pages (and subpages) about Git usage and Drupal best practices:
http://drupal.org/documentation/git
http://drupal.org/node/360052
Comment #12
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.