Cannot remove/uncheck previously set authentication for endpoint

How did you turn on an authentication module for Drupal 7? I wasnt aware of any that existed for Drupal 7 yet.

You could have turned on sessauth in a previous dev, and then suddenly had it disappear when we removed it. I had thought about writing an update path but chose not to. My bad.

Heyrocker can this be closed then or what?

Hmmmm this seems like it's looping through the listed schemes without validating if they're checked or not; plus, it also seems like the empty array is still considered a valid selection.

Line 318:

$auth = array();
  if (isset($form_state['values']['authentication'])) {
    foreach (array_keys($form_state['values']['authentication']) as $module) {
      if (isset($endpoint->authentication[$module])) {
        $auth[$module] = $endpoint->authentication[$module];
      }
      else {
        $auth[$module] = array();
      }
    }
  }
  $endpoint->authentication = $auth;

Here's a patch:

$auth = array();
  if (isset($form_state['values']['authentication'])) {
    foreach (array_keys($form_state['values']['authentication']) as $module) {
      //if module's checkbox is checked (if checked, input value is the module name in the current setup)
      if ( $module == $form_state['input']['authentication'][$module]) {
        if( array_key_exists($module, $endpoint->authentication) ){
          $auth[$module] = $endpoint->authentication[$module];
        }else{
          $auth[$module] = array();
          //if this a new entry, redirect to auth options page
          $form_state['redirect'] = 'admin/config/services/services/' . $endpoint->name . '/authentication';
        }
      }
    }
  }
  $endpoint->authentication = $auth;

Updated patch with style cleanup.

IM fixing this to be way better :P stay tuned.

Here we go, try this on for size.

Theres three bugs, one, authentication was always being used if the module was enabled, regardless of if the endpoint enabled it.
Two, the authentication section for each endpoint was always displaying options even if the endpoint didnt have the auth enabled
Three the actual edit page for the endpoint was not properly checking previous endpoint values.

These have all been resolved

this version is 6.x right now ill port to 7.x shortly.

There is another problem I have found and fixed in attached patch.

When we add some settings on auth method (for example context in oauth) they get overriden when we edit and save endpoint on its edit form. This happens because ctools execute default method edit_save_form($form_state) of ctools_export_ui class. I have added empty implementation of this method to services_ctools_export_ui class.

Maybe it is reasonable to move our submit function services_ctools_export_ui_form_submit() to edit_save_form() method of the class?

The is also some code style cleaning added.

I have also removed 'Save' button on Authentication form when there is no auth modules enabled.

So, this patch was for 6.x, this needs to be ported to 7.x now

Ok this is finally fixed.

I'm not sure if I should be posting this here...
But I cant delete endpoints after creating them.

Is this the way it is supposed to be, or am I missing something?