Closed (fixed)
Project:
HTML5 Tools
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Jan 2011 at 02:09 UTC
Updated:
2 Mar 2011 at 22:51 UTC
Jump to comment: Most recent file
$submitted contains put publication date information and author information. Both need to be HTML5ifyed.
Also — $date and $name should be HTML5ifyed.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 1036784-override_submitted-10.patch | 2.58 KB | amateescu |
| #9 | 1036784-override_submitted-9.patch | 2.52 KB | amateescu |
| #8 | 1036784-override_submitted-8.patch | 2.33 KB | amateescu |
| #6 | 1036784-ab-2.patch | 1.47 KB | alanburke |
| #5 | 1036784-override_submitted-4.patch | 1.46 KB | amateescu |
Comments
Comment #1
betz commentedFollowing patch overrides $submitted with a custom theme function.
Does not work in Bartik for now, because Bartik overrides $submitted, without no reason as far as i can see.
I will create a patch for Bartik now
Comment #2
pontus_nilssonFixes typo in last patch (hook_preprocess_hook => hook_preprocess_node)
Comment #3
betz commentedI dont think there is a nice way to html5ify the $name variable.
is for citing works or persons, so something else.
Tthe RDF module already added extra metadata like typeof="sioc:UserAccount" and property="foaf:name"
Comment #4
betz commentedand the bartik patch http://drupal.org/node/1051164
Comment #5
amateescu commentedThis is exactly what I was working on at DDD Brussels :)
Patch looks very good, I think we should also add a 'pubdate' variable which defaults to TRUE.
Comment #6
alanburke commentedPatch rerolled, with pubdate as per the HTML Doctor suggestion.
http://html5doctor.com/the-article-element/
Comment #7
ericduran commentedWe should probably prefix our theme functions with out module name, html5_* is way to generic and may be used somewhere else.
We could also provide our own hook_date_formats to set up the RFC format Instead of passing the custom flag to format_date.
Also should we used element_set_attributes and drupal_attributes instead of doing datetime="' . $variables['rfcdate'] . '". I know this is not an element but just curious. I haven't tested it but I think that should work.
Comment #8
amateescu commentedSome work in this direction. The element and drupal_attributes parts are not done yet.
Also, changed rfcdate to isodate, because we have to provide the date in ISO 8601 format: http://html5doctor.com/the-time-element/
Comment #9
amateescu commentedI see what you mean with drupal_attributes, attached patch implements that and cleans a bit our theme function.
My example was theme_filter_guidelines() from core's filter.module.
Comment #10
ericduran commentedThe type name should probably be html5_tools_iso8601. Sadly we still need to worry about namespace collision and iso8601 might be a format a multiple modules will want to implement.
Besides that everything else looks good, we just have to change the type everywhere is mention.
Powered by Dreditor.
Comment #11
amateescu commentedDone :)
Comment #12
ericduran commentedThis looks good to me.
Comment #13
dave reidWe should probably add some kind of note if this functionality prevents modules like Submitted By from working.
Comment #14
amateescu commented@Dave, we can't know (or fix) that until a 7.x release for that module is published.
Comment #15
ericduran commentedWe probably should have a configuration screen where settings like these can be turn on or off. It is pretty uncool to just do stuff without telling people whats going on.
Comment #16
jensimmons commentedYes, let's put everything in a config page. I opened an issue for this. #1063786: Create a configuration screen for HTML5 Tools options
Comment #17
ericduran commentedThanks for all the work amateescu. I committed the last attached patch since the other issue shouldn't hold this one up.
--
http://drupal.org/cvs?commit=501306