Inline: Drupal 7 port

Subscribing

Subscribing… added the Drupal 7 (D7) tag as well.

From what I can see, there is no upload module in Drupal 7 anymore. They are supposed to be replaced by file fields, which confuses me - since you can only put one file into it. Does anyone know what happens to attachments when you upgrade from D6 to D7? Will all attachments be thrown away?

Not sure how this will affect inline. If there are no attachments, would it have to work with field references or something?

If you dig into the file field option you'll find a way to add more than one file.. I guess this is how multiple uploads will be converted when updating from D6 to D7.

Btw, inline needs porting to D7 or a script for migrating into something else (eg. media module).

Javier, from what version of Inline did you start from? Also, consider posting a patch—it's much easier for developers to apply and use.

I won't have time to properly review this patch for another 2 weeks.

Javier, how confident are you that the patch is 100% correct?
Are you willing to investigate bug reports for the patch?

I'm happy to clean up this patch and commit it if someone else reviews/supports it.

I have cleaned up this patch a little, reverting whitespace changes, fixing some Drupal style issues etc.
I also back-ported the changes from the 6.x-1.x-dev branch into this patch which was based on the 6.x-1.0 release.

I don't have a Drupal-7 installation running, so this code has been committed untested. Apologies if I've broken anything!

This new code has been pushed to a new branch, 7.x-1.x and a new 7.x-1.x-dev release created.

HEAD still contains the 6.x-2.x branch which I guess I should push into a branch of its own.

Thanks Javier, this is a really good start for inline's Drupal 7 compatibility!

+1

sub

subscribe

I have committed that patch, thank you!!

There was an issue that came up regarding dependency on the Upload module in D6. I changed the dependency to D7's core File module, and it seems to be working fine.

http://drupal.org/node/1173396#comment-4600550

I'm upgrading a 6.x website where I was using inline to 7.x. The inline version published here (and on 7.x-dev) didn't work for my setup (just after running update.php ). Basically this 7.x version seems to look for image fields only while all the file upload fields converted from my 6.x install have been installed as general files.

Inline 6.x was working not only on image files but also on general files (by placing an "a" tag instead of "img") so I think that this version still needs work.

What I've done so far is http://sprunge.us/VjRZ .. I removed the checks for "image" fields so that now it should work for general file fields. Right now it somehow work in my setup, the only problem is that the file has to be set as "display" in order to be loaded from inline.

Thanks for working on this. Not really sure whether the committed patches are an actual improvement, but quite possibly, a step forward.

Committed attached patch as a follow-up.

I agree that some one-liners are a step forward, but
ea7ee598885a4030105eb6c9272a35c8179ae03e mostly changes whitespaces (generated without diff -w) and move functions around without a strong reason for this ! (does anyone really think that code-indentation is the main problem/priority of D7 Inline)
There are others issues (some of them with patches) waiting in the queue which will have to be rerolled... (like mines in #1309542: D7 core File field is not handled by Inline & #1328260: $file->title not correctly tested, inexistant $file->filepath and missing file_create_url() for images :) )

nb: some people are not using nor doing business with Drupal and only contribute to make this CMS better/easier for associations/ngo, ... please don't make our lifes harder : consider commenting issues (and/or pending patches) about functional changes before trivial ones.
thx

@drzraf: Exactly. However, to clarify, the commit you mentioned (same as patch in #21) reverted the needless/bogus white-space changes and movement of functions to their original locations. This is important for maintenance across major versions of this module (e.g., backporting of bug fixes, etc).

Will try to look at the other patches ASAP, if no one beats me to it. Thanks!

Thanks!

Looks fine to me! :)