Hi,

I am seeing a few cross-browser compatibility issues. I'll submit the others later because I am not sure if this is where I am supposed to submit code fixes.

in jrating.module starting on line 294. You have:

  return '<div class="rating" id="rating-mean-' . $nid . '">' . t('Average rating') . implode("\n", $stars) . '<div class="num-votes">(' . $num_votes_html . ')</div></div>';
}

In Safari and a few other browsers on my mac the text breaks the stars. If you put in this code it fixes that, however there are still issues with the floating and padding:

  return '<div class="rating" id="rating-mean-' . $nid . '">' . t('Average rating') . '<br />' . implode("\n", $stars) . '<div class="num-votes">(' . $num_votes_html . ')</div></div>';
}

Comments

hickory’s picture

hickory commented
Assigned: Unassigned » hickory

I think a better fix would be to put the 'Average rating' text in a div of class 'rating-intro', like the 'Rate this' text. Will fix this, and if you find other incompatibilities, yes, please post them as issues here.

hickory’s picture

hickory commented
Priority: Normal » Critical
Status: Active » Fixed

This should be fixed now, hopefully.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
AstralP’s picture

AstralP commented

I solved this problem by adding:

      $node->jrating_votes = theme_jrating_average_rating($node->nid, $vote = FALSE);

after the $node->html line and then disabled average ratings in the settings. This moves control over to the phptemplate theme makes it much easier to theme and also allows placing the two parts at different locations, which is the main reason I did it. It also solved the star stacking problem by using a new float div to contain each part.

Extremely good module btw, I spent a long time trying to get fivestar sorted and thankfully came across jrating.