Needs work
Project:
backup
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
17 Dec 2006 at 03:51 UTC
Updated:
21 Feb 2007 at 10:52 UTC
Jump to comment: Most recent file
That's the dream anyway. Attached is what I've got so far, which is actually working on a site in development.
A couple of caveats:
Would love to hear your feedback.
-Matt
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | backup_s3_0.patch | 6.64 KB | matt@antinomia |
| backup_s3.patch | 6.6 KB | matt@antinomia |
Comments
Comment #1
dmuth commentedHoly crap that's awesome!
I investigated S3 awhile ago, but one thing that has stopped me from wanting to do more with it is the requirement of installing PEAR modules (ugh) and then patching the HTTP_Request module. I don't think it's reasonable to expect users to have to do that, nor is that going to scale well.
(On an unrelated note, I personally have found it frustrating that there don't seem to be any decent command line tools for interacting with S3. :-( )
But I think S3 would be great to have in eventually. Maybe we can find an easier way to make it work?
-- Doug
Comment #2
matt@antinomia commentedMmm. but PEAR is sweet and juicy :)
I completely agree that this is not going to scale, and is not ready for distribution. But wanted to get it out there in the hopes that people smarter than myself can perhaps help fix the misgivings of this patch. I also forget to mention the whole PEAR/HTTP_Request hack as one of the caveats. My hope is that the work that is being done on the File API will bypass all of this mess. In the meantime, though, this is what I came up with after losing 1000 lines of code this past week, and for me, is well worth the hacking involved in implementing it.
That's a good point about a CLI for S3. I hadn't looked into it at all.
How about this figure? The monthly cost of transferring and maintaining a 50 MB backup 1) hourly for the past day and 2) daily for the past month is about $7.50/mo. Sounds like a value to me.
Comment #3
matt@antinomia commentedIt's also worth noting that the HTTP_Request issue was described as being a "bug" in 1.30. If indeed it is a bug, perhaps it's been fixed in the (current) 1.40 version of the PEAR module.
Comment #4
matt@antinomia commentedCrap, there's a typo on one line of the patch. Please use this attached one instead.
Comment #5
ggaudrea commentedHi!
I'm Geoff Gaudreault, and I wrote the S3 Class you cite in your description. You can feel free to package the class in your patch, so long as you do not remove the attribution in the source code. I should probably not be so lazy and actually release it under a specific license. If I did, it would be under the BSD License. Regardless, feel free to use it!
Cheers!
Geoff
Comment #6
dmuth commentedCool! Thanks for the note, Geoff. That certainly makes things easier going forward.
-- Doug
Comment #7
matt@antinomia commentedThanks Geoff, I didn't realize you were active over here at Drupal.org. Do you know why I'm unable to figure out how to set the key or key id using the class?
$transfer->keyId = '##SECRET KEY##';doesn't seem to transfer the variable.I believe the policy is that it's supposed to be GPL in order to go into the Drupal repository. That's the reason, for example, that you must download TinyMCE from Moxiecode as part of the tinymce.module installation process. Bop me on the head if I'm wrong about this.
Comment #8
toemaz commentedI'ld like to test your patch. Just one question before I start: is there a limitation to the size of the tar?
My backup file would be around 100 MB.
Thx!