Had other fixed issue, updated and ran update script. Now I can not see parts of the form. See image for details.

CommentFileSizeAuthor
#15 Screenshot.png63.58 KBdustout
#7 1037428-form_elements_missing-D7.patch3.59 KBbarrett
error.png203.4 KBspaz5915

Comments

Anonymous’s picture

Anonymous (not verified) commented

I already fixed the code, but before to commit it, I will test on my test site, which needs to be updated. As soon as I update the local site, and test the new version of the code, I will commit the code to CVS.

BenK’s picture

BenK commented

Subscribing. Looking forward to the commit and possible a new release?

erikvip’s picture

erikvip commented

Subscribing - any ETA on the commit??

Can we get the unstable version at least, I'm more than happy to test it.

chriz001’s picture

chriz001 commented

subscribe

barrett’s picture

barrett commented

I'm assuming this is abandoned, but I'll leave what I found in case anyone takes it up again.

The Access Type radios aren't displayed because the getStatusOptions method which sets the options in the form function returns an empty array. The cause is that the user_restrictions_user_restrictions_info function (see user_restrictions.module: 91) is passed an array rather than a single string (see user_restrictions.classes.inc: 179).

That's also what's causing the Type Options to not be displayed, as the getTypeOptions uses the same module_invoke(...) call, just with different parameters.

Display issues with the form aside, on submit, none of the values from the are written into the object which is saved.

barrett’s picture

barrett commented
Priority: Normal » Critical

The aforementioned problems make the module unusable, so I'm marking them critical lest someone think the module still functions.

barrett’s picture

barrett commented
StatusFileSize
new 1037428-form_elements_missing-D7.patch3.59 KB

The attached patch fixes the issues with the form elements and writes the values from the form onto the resulting object for saving. It also addresses the issue reported in #1036846: Code passes the wrong argument to a database function

The module is still non-functional, but at least this bit works now.

Anonymous’s picture

Anonymous (not verified) commented

subscribe.

jmvidal’s picture

jmvidal commented

subscribe.

Anonymous’s picture

Anonymous (not verified) commented

Does anyone know of an alternative way to implement restrictions, through some other module or otherwise? doesn't look like this module will be getting off the ground and in working form....

obiwankaynobi’s picture

obiwankaynobi commented

ditto

d0t15t’s picture

d0t15t commented

ja i'm in the same boat - looking for a module that allows users to block content access to specific users. Basically block access by user reference. any ideas?

d0t15t’s picture

d0t15t commented

the patch fixes the display issue, but i have not been able to successfully save a rule. doesn't create a log of any error, just seems to not do anything.

dustout’s picture

dustout commented

i'm having the same issue, this is a pretty bad bug

dustout’s picture

dustout commented
StatusFileSize
new Screenshot.png63.58 KB

I have applied this patch, it corrects the form issue, however the access restriction is still not successfully applied

clicchick’s picture

clicchick commented

Is this module still unusable?

marco’s picture

marco commented

I wrote a patch trying to make the module usable, I'd be grateful if you could review it:
http://drupal.org/node/1214080

thank you

clicchick’s picture

clicchick commented
Status: Active » Needs review
skizzo’s picture

skizzo commented
Status: Needs review » Closed (duplicate)

Marco's patch works for me.
Marking as duplicate of http://drupal.org/node/1214080