Any plans to port this module to D7?

Comments

bacchus101’s picture

bacchus101 commented

subscribe

Bastlynn’s picture

Bastlynn commented
Assigned: Unassigned » Bastlynn

Yep! Dice roller is on my to do list for upgrades, I'm currently getting familiar with the process on a few smaller modules I'm also a maintainer for. :)

I'm glad someone else is using it! Thanks for the interest :)

Orjan’s picture

Orjan commented

I'm not using it now, but I'm currently building a site where this is more or less required functionality... So the sooner this gets to 7.0, the sooner the users will find the site useful. I's going to be a game and rpg site in Swedish, so I hope it's made by using t() for all output, so I can translate the module...

Bastlynn’s picture

Bastlynn commented

t() is used throughout the code what I remember. I'll double check to make sure the 7 version is doing that if not.

General gaming or a specific system/setting?

The reason I ask is because the module is designed to be extensible for specific system needs, White Wolf for example with their 1's cancel success rule would be a good sub module. So if you have a particular system in mind that I'm familiar with, I may have some additional code to bump up in the priority list for D7.

(Most of my favorite settings are more popular in Europe for some reason. ;) )

Orjan’s picture

Orjan commented

General. We are a gaming society playing many different games. I'm not a rpg player myself, just board games, l but I'll ask for our most used systems :-)

Bastlynn’s picture

Bastlynn commented
Version: 6.x-1.4 » 7.x-1.0
Status: Active » Needs review

Let me know how the new update at ( http://drupal.org/node/1106578 ) works for you.

Orjan’s picture

Orjan commented

Oh, how nice! I just installed the module. Had some tough time finding how to really enable it properly, Finally I found it, but a little bit better description might be in place, it was so hidden there. Maybe it's possible to join the enabling into the other settings for the content type instead (the part that Vertical Tabs for D6 made nice)

I've asked my fellow users to try it out, but from what I can see, it works fine. I've also provided an Swedish translation at localize.drupal.org but it needs to be approved first.

Bastlynn’s picture

Bastlynn commented

I should be able to get the settings on tab. But since you have to go to the dice setting page to activate any additional types of rolls from Basic anyway, perhaps a link from the module installation screen to configurations would work instead?

Orjan’s picture

Orjan commented

It would work fine like that!

An error I found is when you have rolled on a post, edit the post and try to roll again. I get
Fatal error: Cannot use object of type stdClass as array in /home/****/public_html/sites/all/modules/dice_roller/dice_roller.module on line 235

This should at least be handled in some way :-)

Bastlynn’s picture

Bastlynn commented

Ok, try http://drupal.org/node/1116968

I must have completely blanked on the comment update function - is fixed now in 1.1

But I wanted to add some more features, and tagged before I remembered to put them in - so 1.2 has, in addition to the fix, a way to adjust field display for the dice results so you can rearrange the display. It also has the link to configuration from the modules page, and I've moved the Dice roller configurations for each node type into the tabs for the node type.

Orjan’s picture

Orjan commented

Great progress! And I see you added the text strings for the different modifiers to the standard t() format, that's what I was missing in my translation. When I got time, I'll translate those lines too. All in 1.0 is completely translated into Swedish at localize.drupal.org

I think it's wonderful! Looks like everything I have seen now is working.

One thing I've thaught of is rerolling. I've understood that some rulesets has reroll on X in some cases, could this be implemented?

5d6.reroll(6) = 4, 6 => 4, 5, 2, 3 = 18
the 6 is rerolled to 4. if it had rolled 6 again, it would stay 6

5.d6.rereroll(1) = 4, 1 => 1 => 5, 3, 1 => 6, 4 = 22
the 1 is rerolled to 1, which is rerolled again to 1 and kept rerolled until not 1

Bastlynn’s picture

Bastlynn commented

That would make a great add on to either the basic module or as another extension module.

If you're a coder, do you feel like giving the dice API a test run? I might not get around to adding the feature for awhile. (Work is about to drop a very large project in my lap.)

Bastlynn’s picture

Bastlynn commented
Status: Needs review » Closed (fixed)

Setting to closed - feel free to post a module or new feature request for the additional rolls, I just want to get this ticket closed in the meantime.