A user having priviliges to adminiser nodequeue other than admin is not able to add his story to nodequeue. when he clicks on the nodeque tab "No queues are defined for this item" appears.

Still he can administer queue, have the privilige to administer content.

CommentFileSizeAuthor
#2 patch_103781_2.diff1.91 KBmansion
#1 nodequeue_roles.patch955 bytesgreggles

Comments

greggles’s picture

Version: 4.7.x-1.x-dev » 4.7.x-1.1
Status: Active » Needs review
StatusFileSize
new955 bytes

I have this same issue and found it was some missing arguments in the sql.

I've attached a patch which allows users with the proper permissions to see the nodequeue.

mansion’s picture

StatusFileSize
new1.91 KB

Your patch is wrong. You will get lots of notices with it and it won't work.
I suggest this one instead.

greggles’s picture

I don't know what to say other than my patch "works for me".

mansion’s picture

No it doesn't...
You are using array_merge() for merging a scalar ($type) and an array ($roles). Furthermore, $roles might not even exist when you try to merge it, so, as I said, you will get notices (if only you took care of enabling E_ALL error level, like every developer should do).

greggles’s picture

I don't know which way is the "right" way per se but I can now confirm that mansion's patch works for me.

mansion, I do appreciate your tips.

njivy’s picture

Status: Needs review » Reviewed & tested by the community

Works for me.

njivy’s picture

Clarification: It applied cleanly and with the desired effects on the 5.x-1.1 edition.

merlinofchaos’s picture

Changes in the -dev version made this patch not apply; I mostly redid it by hand and I think I have it right, but I would seriously appreciate a doublecheck.

merlinofchaos’s picture

Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)