Closed (fixed)
Project:
Nodequeue
Version:
4.7.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Dec 2006 at 12:18 UTC
Updated:
13 Mar 2007 at 19:46 UTC
Jump to comment: Most recent file
Comments
Comment #1
gregglesI have this same issue and found it was some missing arguments in the sql.
I've attached a patch which allows users with the proper permissions to see the nodequeue.
Comment #2
mansion commentedYour patch is wrong. You will get lots of notices with it and it won't work.
I suggest this one instead.
Comment #3
gregglesI don't know what to say other than my patch "works for me".
Comment #4
mansion commentedNo it doesn't...
You are using array_merge() for merging a scalar ($type) and an array ($roles). Furthermore, $roles might not even exist when you try to merge it, so, as I said, you will get notices (if only you took care of enabling E_ALL error level, like every developer should do).
Comment #5
gregglesI don't know which way is the "right" way per se but I can now confirm that mansion's patch works for me.
mansion, I do appreciate your tips.
Comment #6
njivy commentedWorks for me.
Comment #7
njivy commentedClarification: It applied cleanly and with the desired effects on the 5.x-1.1 edition.
Comment #8
merlinofchaos commentedChanges in the -dev version made this patch not apply; I mostly redid it by hand and I think I have it right, but I would seriously appreciate a doublecheck.
Comment #9
merlinofchaos commentedComment #10
(not verified) commented