The "disable rich-text" link throws off the display of themes. See https://img.skitch.com/20110124-jx9weiintfin3df8b2ga6btgn6.jpg for an example. Can we move this to a better location. Maybe tabs like Gardens is using.

Comments

gmclelland’s picture

StatusFileSize
new28.31 KB
new40.21 KB

I agree see the before and after screenshots attached.

.filter-wrapper has a border-top:0 which should be removed when showing a wysiwyg editor or you could just remove it and it would look fine all the time.

twod’s picture

Issue summary: View changes
Status: Active » Fixed

I've committed a small fix which moves the "Disable rich-text" link into the format selector fieldset, for a slightly better look.
I'm hesitant to override the .filter-wrapper style in Wysiwyg since it would affect things even if the filter is disabled. Perhaps I could add/remove a wysiwyg-specific class on some element and target that class for the border override, so themers could use it as well.

However, I think it's probably easy enough for themers to always force the border to show if they're annoyed by the small border gap which now appears below some of the editors.

If this fix isn't enough, please re-open the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joegraduate’s picture

Status: Closed (fixed) » Active

This change has introduced a problem for me on sites where I use the Better Formats module to restrict which filter formats are available per node type.

When a node type is configured to only allow only ONE format, Better Formats actually hides the format selector widget in the node edit form by setting its FAPI #access attribute to FALSE (which is apparently similar to what Drupal core does when only one filter format has been configured on a site).

So now when this module tries to prepend the "enable/disable rich text" toggle link to the format selector (or it's parent/closest fieldset-wrapper) on the node form of node types configured this way, the format selector field doesn't exist so the toggle link is never rendered either.

twod’s picture

Status: Active » Needs review
StatusFileSize
new811 bytes

Good catch!
Could you try this patch?

joegraduate’s picture

Status: Needs review » Reviewed & tested by the community

Patch in #5 works great! Thanks for the fast response, TwoD!

I have verified that rich-text link is now present on node types configured to only allow one text format as it was before the recent changes (immediately after the wysiwyg field). Also, on node types not configured that way the link appears in its new location (prepended above the format selector widget).

Thanks again!

  • Commit b5f4ca9 on 7.x-2.x by TwoD:
    - #1038336 by TwoD: Fixed missing editor toggler when using a single...
twod’s picture

Status: Reviewed & tested by the community » Fixed

Perfect!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.