Closed (fixed)
Project:
Wysiwyg
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Jan 2011 at 16:36 UTC
Updated:
26 Jun 2014 at 02:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gmclelland commentedI agree see the before and after screenshots attached.
.filter-wrapper has a border-top:0 which should be removed when showing a wysiwyg editor or you could just remove it and it would look fine all the time.
Comment #2
twodI've committed a small fix which moves the "Disable rich-text" link into the format selector fieldset, for a slightly better look.
I'm hesitant to override the .filter-wrapper style in Wysiwyg since it would affect things even if the filter is disabled. Perhaps I could add/remove a wysiwyg-specific class on some element and target that class for the border override, so themers could use it as well.
However, I think it's probably easy enough for themers to always force the border to show if they're annoyed by the small border gap which now appears below some of the editors.
If this fix isn't enough, please re-open the issue.
Comment #4
joegraduateThis change has introduced a problem for me on sites where I use the Better Formats module to restrict which filter formats are available per node type.
When a node type is configured to only allow only ONE format, Better Formats actually hides the format selector widget in the node edit form by setting its FAPI #access attribute to FALSE (which is apparently similar to what Drupal core does when only one filter format has been configured on a site).
So now when this module tries to prepend the "enable/disable rich text" toggle link to the format selector (or it's parent/closest fieldset-wrapper) on the node form of node types configured this way, the format selector field doesn't exist so the toggle link is never rendered either.
Comment #5
twodGood catch!
Could you try this patch?
Comment #6
joegraduatePatch in #5 works great! Thanks for the fast response, TwoD!
I have verified that rich-text link is now present on node types configured to only allow one text format as it was before the recent changes (immediately after the wysiwyg field). Also, on node types not configured that way the link appears in its new location (prepended above the format selector widget).
Thanks again!
Comment #8
twodPerfect!