When using a multiple-value, required link field in D7, you get an extra required indicator above the URL fields. Also, if your link field is required, and titles are requied, when adding a new node/entity, the first title field should also be required.

CommentFileSizeAuthor
#6 1038444-link-extra-required-indicator_retrieved.patch1.69 KBdqd
#1 1038444-link-extra-required-indicator.patch1.85 KBdave reid
#1 1038444-before.png23.14 KBdave reid
#1 1038444-after.png12 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 1038444-after.png12 KB
new 1038444-before.png23.14 KB
new 1038444-link-extra-required-indicator.patch1.85 KB

Patch attached for review, including before/after screenshots. Also confirmed this does not mess up required validation for the form field.

yched’s picture

yched commented
Priority: Minor » Major
Status: Needs review » Reviewed & tested by the community

That's correct.

Also, it seems the #required on title prevents submission of the field settings form when the field is required (the "default value" widget gets a required field) - which is annoying. The patch should fix that.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Reviewed & tested by the community » Fixed

as far as I can see, the issue is fixed in latest dev.
please correct me if I am wrong.

Thanks for patch and report!

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Issue tags: +D7 stable release blocker

Issue seems to stick together with this one
#1217396: "multiple-value" & "required" breaks input/save and produces error: "At least one title or URL must be entered."
which isn't fixed.

... Daves patch would help, but it doesn't apply no more since code has changed from then.
I will try to apply it manually tomorrow.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Fixed » Postponed (maintainer needs more info)
dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 1038444-link-extra-required-indicator_retrieved.patch1.69 KB

Since the sadly never committed patch of davereid from January didn't fit on the newer code automaticly no more, I had to manually apply it and create a retrieved version of it.

Here we go, let me know ...

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Issue tags: -D7 stable release blocker

REMOVED -> D7 stable release blocker

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs review » Fixed
Issue tags: +scheduled for beta1

we got to catch up. I reviewed by myself on 3 test installs. seems to work. committed to latest dev and marked for beta1

Status: Fixed » Closed (fixed)
Issue tags: -scheduled for beta1

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +scheduled for beta1

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.