CVS edit link for trevorwh

Currently doing work as the lead developer on http://drupal.org/project/uc_braintree, have implemented an initial version and torgos created the project for me. To be added as the maintainer I need CVS access to commit the initial version. This project brings gateway support for Braintree Payment Solutions to Ubercart.
CommentFileSizeAuthor
#2 uc_braintree.zip169.48 KBtrevorwh
#1 uc_braintree.zip169.38 KBtrevorwh

Comments

trevorwh’s picture

trevorwh commented
Component: Miscellaneous » miscellaneous
StatusFileSize
new uc_braintree.zip169.38 KB

Added the v1 of Braintree module.

trevorwh’s picture

trevorwh commented
StatusFileSize
new uc_braintree.zip169.48 KB

Added latest version (several bug fixes/moved some code around)

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Status: Postponed (maintainer needs more info) » Needs review

I would like to see trevorwh receive CVS write access. His work so far has been invaluable.

tr’s picture

tr commented
Status: Needs review » Needs work

A big problem is you can't put all that proprietary Braintree code into Drupal CVS and distribute it as part of your module. Your README.txt (which is blank right now) should have instructions for how to download any proprietary code from Braintree's site.

You need to get rid of all the excess junk in your .zip - the svn folders, for instance.

You need to run the Coder module and bring your code up to Drupal coding standards.

Your hook_requirements() shouldn't be doing a check on the PHP version - that's what the php property in the .info file is for.

Boolean constants should be upper case.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

Please read all the following and the links provided as this is very important information about your CVS Application.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:Migrating from CVS Applications to (Git) Full Project Applications.

  • If your application has been "needs work" (or "postponed (maintainer needs more info)"), your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
  • if the status of this application is a different one, it will be changed to "postponed"; you will be able to reopen it by following the instructions in the above link.