The code which checks for user roles forgets to replace spaces with underscores (e.g., "authenticated users"), thus nothing is ever tracked.

CommentFileSizeAuthor
googleanalytics_1.patch434 bytesumonkey

Comments

flanderz’s picture

flanderz commented

I tried the patch and I can confirm its working properly.

rszrama’s picture

rszrama commented

This only covers half the fix... must also be done on the form. I'm uploading a version for 5.0 to the following issue:

http://drupal.org/node/109990

dopry’s picture

dopry commented

In head it appears to be already done in the form. See line 119 of google_analytics.module. It would be easier for the maintainer if you kept everything in a pre-existing issue instead of opening a duplicate.

budda’s picture

budda
Primary language English
Location Cheshire
commented
Status: Needs review » Fixed

The spaces to underscore code has been added to the new DRUPAL-5 dev branch. I don't currently have any Drupal 5 sites to test this against quickly.

I cannot see any reason why the fix would not work though.

If this is fine, I'd like to tag the package as a final 1.0 release for Drupal 5.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)