after creating platform, publish path should not be changeable [#1039168]

If the publish path of a platform is changed, all sites bound to that platform fail to work, aswell as being impossible to fix without manually editting all the drush alias files to the correct path and doing a verify.

Steps to reproduce:
* Platforms tab
* select platform
* Edit tab
* Change publish path to a valid path after moving the physical path (eg: pressflow-6.19.92 -> blah-pressflow-6.19.92)
* Platform is verified properly.
* watch all sites using that said platform start to fail.
* verify any site -> fail.
* disable site -> fail.

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 27 January 2011 at 01:47

The only reason this doesn't work is because we don't queue up a verify of the sites on that platform afterward (all that is missing is that the DocumentRoot isn't rewritten for the site vhost. The platform apache config is rewritten as expected)

But I think we decided a while ago that we didn't want to auto-invoke verifications of sites if a platform node is edited, so in that case, yes we should make this uneditable.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 27 January 2011 at 01:57

Actually this problem is bigger:

Even if the platform name is changed, the context changes, and the Site drush aliases would reference the wrong platform.

So we should in fact auto-re-verify all sites, or make the platform node totally uneditable possibly.

EDIT: I am on crack, it seems we don't even change the context name if the platform name changes.So the alias remains the same as it was (this could even be a bug in itself or by design, don't know)

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 27 January 2011 at 21:34

Status:

Active

» Fixed

now in git, publish path is not changeable for existing platforms.

Comment #4

10 February 2011 at 21:40

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #5

AlfTheCat CreditAttribution: AlfTheCat commented 14 March 2011 at 21:19

Version:

6.x-0.4-alpha3

» 6.x-1.0-rc2

Sorry for editing a closed issue, however on RC1 I ran into the problem that, after making a typo in the publish path, there is no way for me to either get the platform out of the system, or correct the publish path.

So I had to change the platform directory to match my typo in order to be able to verify, delete and restore things.
Seems to me that this is a (minor) disadvantage to this method.