Using the "coder" module, I found a number small "bugs" with regard to keeping the Drupal coding standards defined in these pages:

http://drupal.org/coding-standards

To summarize the fixes (so you don't have to run "coder" yourself):

  • "if else" should be "ifelse"
  • A number of lines used tabs or mixed tabs/spaces, should be only spaces
  • There were a number of calls to l(check_plain(...), ...) where l() already calls check_plain()
  • PHP constants like TRUE, FALSE, or NULL should be written upper-case
  • dictionary.install was missing the @file block

This patch is against dictionary 1.1

Best regards!
David.

CommentFileSizeAuthor
dictionary-1.1-coding-standards.patch7.51 KBdsnopek

Comments

Sara Adams’s picture

Status: Active » Fixed

Thanks! I've submitted this in to the repository.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.