Using the "coder" module, I found a number small "bugs" with regard to keeping the Drupal coding standards defined in these pages:
http://drupal.org/coding-standards
To summarize the fixes (so you don't have to run "coder" yourself):
- "if else" should be "ifelse"
- A number of lines used tabs or mixed tabs/spaces, should be only spaces
- There were a number of calls to l(check_plain(...), ...) where l() already calls check_plain()
- PHP constants like TRUE, FALSE, or NULL should be written upper-case
- dictionary.install was missing the @file block
This patch is against dictionary 1.1
Best regards!
David.
| Comment | File | Size | Author |
|---|---|---|---|
| dictionary-1.1-coding-standards.patch | 7.51 KB | dsnopek |
Comments
Comment #1
Sara Adams commentedThanks! I've submitted this in to the repository.