Hi,

For third-world countries Google Map Maker often does a much better job than the normal Google Maps street map.

This patch adds support for Google Map Maker type base layers.

According to http://maps.google.com/support/bin/answer.py?answer=155714:

"Use G_MAPMAKER_NORMAL_MAP and G_MAPMAKER_HYBRID_MAP in lieu of the
normal map and hybrid types to show mapmaker map tiles and hybrid tiles
respectively. Remember that these serve maps only the countries being
edited in Map Maker, not all the countries available in maps.google.com."

It should apply clean with:

$ patch -p6 < 0001-Feature-6483-Patch-Add-Google-Map-Maker-to-the-avail.patch

in the root directory of openlayers.

Thanks for considering the patch.

Best Wishes,

Fabian

CommentFileSizeAuthor
0001-Feature-6483-Patch-Add-Google-Map-Maker-to-the-avail.patch2.24 KBfabianx

Comments

tmcw’s picture

tmcw commented
Status: Needs review » Fixed

Great, committed: http://drupal.org/cvs?commit=492416

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fabianx’s picture

fabianx commented
Title: [PATCH] Add support for Google Map Maker to the available Google Map types » [REGRESSION] [PATCH] Add support for Google Map Maker to the available Google Map types - New fix.
Category: feature » bug
Priority: Normal » Major
Status: Closed (fixed) » Needs review

Hi Tom MacWright,

Unfortunately my patch was buggy on IE and introduced a bug, which breaks Google Maps.

diff --git a/sites/all/modules/patched/openlayers/includes/layer_types/js/google
index 7a0e43f..ebce970 100644
--- a/sites/all/modules/patched/openlayers/includes/layer_types/js/google.js
+++ b/sites/all/modules/patched/openlayers/includes/layer_types/js/google.js
@@ -19,7 +19,7 @@ Drupal.openlayers.layer.google = function(title, map, options)
     'hybrid': G_HYBRID_MAP,
     'physical': G_PHYSICAL_MAP,
     'mapmaker-normal': G_MAPMAKER_NORMAL_MAP,
-    'mapmaker-hybrid': G_MAPMAKER_HYBRID_MAP,
+    'mapmaker-hybrid': G_MAPMAKER_HYBRID_MAP
   };
 
   options.sphericalMercator = true;

Please apply the above patch to fix this problem.

Best Wishes,

Fabian

tmcw’s picture

tmcw commented
Status: Needs review » Fixed

Committed. Should have caught that, but at this point I'm more a committer than a developer on this project :/

fabianx’s picture

fabianx commented

Thanks!

Nah, I should not have introduced it in the first place ...

I wrote on my chalk.board a 100 times now:

"I will not submit code to drupal org that has not been run through JSLint."
"I will not submit code to drupal org that has not been run through JSLint."
[...]

:-D

Best Wishes,

Fabian

Status: Fixed » Closed (fixed)
Issue tags: -patch

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.