Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I found cache_get($cache)
is wrong and did also other fixes in this function.
---
I wonder what's the intention for this function. It is only used to cache the result of autoadmin_schema_get_all() and $options argument is only used to clear the cache. If it is planned to support caching the result of other functions I suggest this signature:
function autoadmin_cache_function($function, $arguments = array(), $reset = FALSE))
.. and also use call_user_func_array() instead.
Comment | File | Size | Author |
---|---|---|---|
autoadmin_cache.patch | 1.57 KB | jonhattan | |
autoadmin_cache.patch | 0 bytes | jonhattan |
Comments
Comment #1
_rune CreditAttribution: _rune commentedHi
I no longer have plans to cache other functions with it and think it should be removed.
Cheers
Rune
Comment #2
_rune CreditAttribution: _rune commentedRemoved dependency on the function completely in version 1.7. Thanks for the patch though!
Comment #3
_rune CreditAttribution: _rune commentedReopening, I messed up the fix. Fix tomorrow.
Comment #4
_rune CreditAttribution: _rune commentedFinally fixed in v. 1.8. I _really_ hate this cache pattern and starts to remember why I made the blasted cache function in the first place :)