Closed (fixed)
Project:
Auto Admin
Version:
6.x-1.5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Jan 2011 at 20:19 UTC
Updated:
26 Jan 2011 at 10:22 UTC
I found cache_get($cache) is wrong and did also other fixes in this function.
---
I wonder what's the intention for this function. It is only used to cache the result of autoadmin_schema_get_all() and $options argument is only used to clear the cache. If it is planned to support caching the result of other functions I suggest this signature:
function autoadmin_cache_function($function, $arguments = array(), $reset = FALSE)).. and also use call_user_func_array() instead.
| Comment | File | Size | Author |
|---|---|---|---|
| autoadmin_cache.patch | 1.57 KB | jonhattan | |
| autoadmin_cache.patch | 0 bytes | jonhattan |
Comments
Comment #1
_rune commentedHi
I no longer have plans to cache other functions with it and think it should be removed.
Cheers
Rune
Comment #2
_rune commentedRemoved dependency on the function completely in version 1.7. Thanks for the patch though!
Comment #3
_rune commentedReopening, I messed up the fix. Fix tomorrow.
Comment #4
_rune commentedFinally fixed in v. 1.8. I _really_ hate this cache pattern and starts to remember why I made the blasted cache function in the first place :)