I wanted to see if the custom search module community would like a patch that lets custom search module integrate with panels 3.

CommentFileSizeAuthor
#1 1040078_panels3_integration.patch2.08 KBchriscalip

Comments

chriscalip’s picture

chriscalip commented
StatusFileSize
new 1040078_panels3_integration.patch2.08 KB

Here's what the patch will do:

a.) If Panels is already handling the search results page let panels do its own thing.

Please review and improve.

kind regards,
Chris Calip

jdanthinne’s picture

jdanthinne commented
Status: Needs review » Fixed

Thanks, committed to DEV.

chriscalip’s picture

chriscalip commented
Status: Fixed » Closed (fixed)
asb’s picture

asb commented

An very interesting approach. Is anyone already using this patch?

chriscalip’s picture

chriscalip commented

Well I used it in a few production sites.

asb’s picture

asb commented
Version: 6.x-1.x-dev » 7.x-1.10
Status: Closed (fixed) » Active

The patch from #1 went into the dev version in January 2011, the latest official release was published in June 2012, so I assume, the patch should be included in custom_search-6.x-1.10, right?

However, if I enable the 'search-node' override for /search/node/!keywords at ./admin/build/pages/list and then add a variant, I'm just getting the "normal" widgets provided by Panels, not the customizations from 'Custom search'. Do I need to configure something else, e.g. add contexts, or is this the intended behaviour?

Thanks!

asb’s picture

asb commented
Version: 7.x-1.10 » 6.x-1.10

Sorry, wrong branch…

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Fixed

This is an old issue. I'm marking it fixed but if you disagree, please update and provide additional information.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

asb’s picture

asb commented
Status: Closed (fixed) » Active

There is no response to #6, and there's nothing more to add until this has been answered.

jdanthinne’s picture

jdanthinne commented

@asb: still for the 6.x branch? If anybody uses Panels a lot (I don't), a patch is welcome.

asb’s picture

asb commented
Status: Active » Closed (won't fix)

Yes, I'm stuck on D6 with two dozend sites that rely on modules that will not be ported beyond D6 (e.g. the legacy 'Image' module. However, I can't provide a patch, so this is most probably a "won't fix".

jdanthinne’s picture

jdanthinne commented

Well, I can try to find an answer to your problem if you give me a simple way to reproduce the bug (modules versions and configuration from a fresh install would be perfect)…