Search and reference not working with OpenAtrium. It just works with Garland but not with theme Ginko. More debug on this tomorrow

Comments

alippai’s picture

With Rubik it's OK.

alippai’s picture

function ginkgo_preprocess_views_view_fields(&$vars) {

Messes the things up. Working on how to avoid it.

drclaw’s picture

I think the problem is actually rooted in the function:

ginkgo_preprocess_views_view_table(&$vars)

Actually, more specifically in the template file: views-view-table.tpl.php that this function is the preprocessor for. I think that noderelationships needs the view to be output cleanly from views in order for it's javascript to make the necessary changes to the rows or cells for things like adding onClick events and whatnot. When Ginko outputs the table using it's own template, something gets lost that presumably noderelationships needs to work it's mojo...

Not sure how to fix this yet. Whether it's something in noderelationships or something in Ginko... Any thoughts?

drclaw’s picture

Status: Active » Needs review
StatusFileSize
new1.71 KB

Looks like it was both the preprocess function and the template. I've attached a patch that fixes the problem. It's not the best solution since an atrium upgrade will probably scrap the changes, but as a quick fix it works for now.

The patch should be placed in the root of the Ginko theme and run from the command line with the command patch < noderelationships_fix_search_and_ref.patch (I always include this in case someone who is not familiar with patching comes across this post)

I'm not sure what a more permanent solution is, really. I think possibly doing a sub theme of Ginko would fix it...

In any case, I still don't really think this is a noderelationships problem. It works as designed, I believe, because they can't possibly include handling for every possible thing a person might do to a view in their theme. That being said, I usually like to leave status changes to 'closed' up to the module maintainers so I'll just mark it as needs review for now.

R.J. Steinert’s picture

This module forces Garland on what ends up in the modal for Noderelationships, a work around for as long as Ginkgo is breaking this functionality http://drupal.org/project/oa_noderelationships

But, as soon as you search or use the pager, the selection no longer works. I think this is a bug with the Noderelationships module though http://drupal.org/node/1004792#comment-4582858

d34dman’s picture

patch in comment #4 fails against latest version of open atrium as there is no templates/views-view-table.tpl.php .

d34dman’s picture

Status: Needs review » Needs work
amstel’s picture

#4 worked for me, but I had to change the path to suit my installation