Translation template missing in AF files

Whoops, that definitely needs to get fixed. Thanks for reporting!

Michelle

#2 is intentional. You don't send translated strings to format_plural.

Michelle

The translation system is meant for translating to other languages. While it can be used for changing to a completely different English word, that's not the design. In this case, yeah, you would have to edit the template because you're not going to want to translate post/posts to total. That's not an AF issue, though, just a limitation of the translation system that translates words across the board.

Michelle

Ok, t() added around forum tools menu items in D6. Bumping this up to D7 for porting.

Michelle

Try this

Already ported to D7.

Same for the line 913:
$number_new = t("(!new new)", array('!new' => $number_new_comments));
shouldn't it be like:
$number_new = format_plural($number_new_comments, '(1 new)', '(@count new)');
to be translated properly?

Well, either way will translate so it's not missing but, yeah, format_plural makes more sense. I may not have known about the function when that line was written. :)

I'm basing my response purely on #11. I haven't looked at the code to see if there's a reason why it was done that way but I can't think of any off the top of my head.

Yeah. It is definitely not 'missing' because I can translate it :) I haven't noticed this subject updated by me wasn't anywhere near the real issue :)

Text for the links to the new comments in the Posts column (Topics list) cannot be translated at the moment and it should be changed too. Current version of Views module (6.x-2.16 in my case) does support translations including plural forms for translatable strings. To make it working you just need to replace this:
advanced_forum_active_topics.view: 312

    'prefix' => 'View ',
    'suffix' => ' new',

with this:

    'format_plural' => 1,
    'format_plural_singular' => 'View 1 new',
    'format_plural_plural' => 'View @count new',
    'prefix' => '',
    'suffix' => '',

And it will work as it should.

And here's the patch... You should place it to /includes/views and then apply.

Assigning issues you've worked on to you Ingumsky, so I can see which ones you haven't.