Closed (fixed)
Project:
Drupal core
Component:
comment.module
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
28 Aug 2004 at 19:37 UTC
Updated:
7 Oct 2005 at 06:40 UTC
Jump to comment: Most recent file
If a user (for whatever reason) tries to post to a node which doesn't allow this, he currently doesn't get an error message. This patch fixes this.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | comment_2_0.diff | 723 bytes | killes@www.drop.org |
| comment_2.diff | 701 bytes | killes@www.drop.org |
Comments
Comment #1
killes@www.drop.org commentedrecategorizing to show up in the patch queue.
Comment #2
Steven commentedI'm not 100% sure about this patch. We don't normally cater to inaccessible forms. I suppose the comment form is a candidate, when a moderator disables commenting on a (heated?) topic while people are still typing replies.
But are there more probably situations like this out there?
Comment #3
killes@www.drop.org commentedAs you mentioned the comment form isn't neccessarily inaccessible, the sending of the comment might become later. We should present a meaningfull message to the user in that case. I am developing a module where you can only comment for a limited amount of time, so no message is actually confusing.
Comment #4
dries commentedI don't think this needs fixing.
Comment #5
killes@www.drop.org commentedI disagree. The user doesn't get a 403 or anything, just an empty "Post comment" page.Tha's bad usability.
Comment #6
drumm+1
Although it is a rare case, this is a really simple fix that might as well go in.
Comment #7
killes@www.drop.org commentedUpdated to cvs. Better wording.
Comment #8
TDobes commented+1 from me too... although with one minor complaint: we want to say "post" rather than "posts" in the error message.
Although this is a rare case, it is one users may sometimes encounter... and a total lack of feedback as we have now is bad.
Comment #9
Steven commentedThere appears to be a similar message in core already now.
Comment #10
killes@www.drop.org commentedIf I am not totally mistaken, this is just a watchdog message. I want user feedback. this is needed for the evaluation.module where after some time the postign to nodes gets disabled.
Comment #11
Steven commentedErr no:
Note the drupal_set_message(). Granted, the text is quite user-hostile.
Comment #12
(not verified) commentedComment #13
trigear@drupal.trigearproductions.com commentedComment #14
(not verified) commentedComment #15
(not verified) commentedComment #16
(not verified) commented