Fieldset titles sometimes invisible in Garland

I've noticed this also - resizing the window or opening an adjacent fieldset usually makes the fieldset titles reappear.

FF2/WinXP: Consistently reproduced at user/#/edit - The "Comment settings" (signature) fieldset is missing it's "legend".

IE7/WinXP: Fieldset legends are in the wrong place (not on the edge of the fieldset).

Opera 9/WinXP: Everything seems to be OK.

This may be a Garland issue - everything seems to appear correctly under bluemarine.

I am experiencing this with a custom module I'm doing, thought I was crazy :) Goes away in PushButton, it seems to be Garland / Minelli specific.

Forgot to add - FF2 and WinXP too. Its ok in IE7 for some reason. The title reappears if I open my firebug extension subwindow.

Verified on the /user/#/edit page in Firefox 2 (Ubuntu Linux). The comment settings (signature) title is consistently missing in display (but is in the HTML code obviously).

I just noticed that this is now happening intermittently on drupal.org at user/#/edit (FF2/WinXP)

I confirm - happens at Drupal.org user/#/edit, FF 2.0.0.1 / Win 2000. Normally loading the page via link - all OK. After refreshing the page - collapsible fieldset-titles invisible (always), reappears after window resizing (or anything causing FF to re-render content). This means it is FF2 bug (anyone experienced with bug reports to Mozilla?)

I also confirm it's version and/or theme specific - I never once reproduced this on Drupal 4.7.3 with our custom theme (based on SpreadFirefox), as well as number of other themes including PushButton and Bluemarine. (During the same session with FF2)

Generated HTML viewed in FF "Web Developer Toolbar" (i.e. final version rendered, after all JavaScript influence) is identical on fieldset-labels (Drupal.org vs our site), so the only difference I see is in CSS, where drupal.org have no line-breaks / our site overrides the default CSS on fieldset-labels.

FF 1.5 FF 2.0 on WinXP. Same problem. This does it for me:

fieldset legend {
  display: block;
  }

That match. On our site (4.7.3/custom theme/no such problem) the "display:block" IS defined on "fieldset legend", in theme CSS (not drupal.css). At drupal.org I see no such thing in the CSS, there's only definition for child-level "fieldset legend a". This might be the difference confusing FF.

Here's a patch for it. Works well on my site (www.dischargemccain.com).

Tested and added a comment. Committed to HEAD and 5.x.

this patch does not work

update:

#13 works
#15 doesn't

#13 should be in drupal 5.2

unclosing

Apparently the patch in #15 is just field, and not field legend as in #13, for the class. That would explain the difference. Can't test right now.

jbrown: what browser are you testing with? #15 seems to have fixed things for me with FF2 on winxp.

I use the latest stable ubuntu/firefox:

Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.2) Gecko/20060601 Firefox/2.0.0.2 (Ubuntu-edgy)

I have just tested it again and I can definitely trigger the bug with #15. I go to admin/build/modules. Most of the time 'Core - optional' does not appear, or appears for an instant and then disappears. Clicking on a link makes it appear briefly before the new page loads.

A screenshot is attached.

With #13 I am unable to trigger it, no matter what I do.

Jonny

both patches #13 and #15 seem to work for me ...

which browser / OS do you use?

#13 works for me. I was not seeing this with IE6 or NS8, only FF2 (until I used Firebug). Running Win XP (SP2).

@ #25 : FireFox 2.0.0.3 on Win XP pro

curious ... I was using patch #13 (fieldset legend { ...), and as soon as I untarred the jstools module to the modules directory and viewed the modules page (ie before enabling any jstools modules) , my collapsible fieldset titles vanished ... I switched to patch #15 (fieldset { ...) and all seems well ... But what is jstools-5.x-0.6 doing ?... I wonder if there's a name conflict or override coming further down the css cascade ?

Whatever this is, this is a browser bug in Firefox. There seem to be multiple ways to trigger it, but the majority of all occurances seem to be gone at least.

I'd say submit a bugreport with mozilla with a stand-alone HTML/CSS file that reproduces the bug.

@ #29 Steven ... Firefox bug : If this were so, wouldn't we expect the problem to occur with themes other than Garland /Minelli ?

I have only been able to find one other report of this problem specifically on another theme - http://drupal.org/node/137651 - the theme is Aberdeen which is based on Garland and apparently inherits the collapsible css part unedited from Garland (see link).

Has anyone managed to reproduce this bug on any other theme?

JohnG: Browser bugs can be trigger by specific styles and rare combinations of tags and such. It's possible no other theme triggers it. That doesn't mean it's not a browser bug.

It's indeed, clearly, a browser bug. Here is how I manage to make the titles appear on my FF 2.0: Click on the firebug icon (on the bottom right, if you have firebug) or click on a link outside the fieldset but drag away before you release. (e.g. don't let it submit) and titles will appear!

Unfortunately, is known to be very buggy in FF. Check: https://bugzilla.mozilla.org/show_bug.cgi?id=269908

That said, I hope there would be a workaround to prevent whatever bug this is from being triggered.

Forgot to escape my HTML, that was:

Unfortunately, <legend> is known to be very buggy in FF. Check: https://bugzilla.mozilla.org/show_bug.cgi?id=269908

nice link alienbrain ... you could fry eggs on that discussion ;-) but there do seem to be a few (apologetic) hints at possible workarounds, though none I could understand :-P

Aside, using a padding in "fieldset legend" will bring the bug back... however there is a display:block; or not. it looks solvable by using padding-right and padding-left as an replacement of padding: 0 .2em;.

  fieldset legend {
    display: block; /* FF fix */
    color: #444; /* IE fix */
    padding-right: .2em; /* FF fix */
    padding-left: .2em; /* FF fix */
  }

Woot! weird as it's, that has worked for me! thanks hass :-)

So everyone else is getting this in Garland eh. I'm working on my own theme and have been getting this bug for a while now. The theme is based originally on Amadou, but I think I've added bits and pieces from Garland too as I'm a Drupal noob and don't really know what I'm doing. If I have time I'll try and see what my theme and Garland has in common that might be causing it.

Other themes are getting it too (for example, Aberdeen). It's a Firefox issue.

I've encountered the problem in garland, barlow and ocadia themes so far. The patch in #35 fixed it for me for all three of these themes. Thanks!

I found the same problem in the Barron theme. Fix 13 cured it, placing the fix just before the existing reference to "fieldset" in style.css.

sadly enough, even #35 did not fix the pb for me

browser :
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.12) Gecko/20070510 Iceape/1.0.9 (Debian-1.0.9-0etch1)

theme: garland

drupal: 5.1

FYI : several other "fixes" were suggested in other places, I just restat that these also didn't fix me :
* print $onloadattibutes; inside < body > --- seems to ba an empty variable
* drupal_add_js(misc/collapse.js) --- this script is already in my header
(in fact, there is a minimal "uincollapsing", but just some pixels)
indeed if there's another filedset on the page, they can mutually unblock each other.
the problem is that e.g. the localizer fieldset for menu entries is the only one on the respective "edit" page

try disabling upload.module:
http://drupal.org/node/162743

Setting to a more appropriate status.

There's another fix for this that doesn't require a fix to the Garland CSS file.

From this patch http://drupal.org/files/issues/misc_0.patch by dkruglyak, in collapse.js add the line...

$(this).prepend(' ');

This adds a space character to the fieldset. I tested this and it works. You don't need the CSS display: block in fieldset legend mentioned in #13. This seems a cleaner solution and only needs 1 line.

FYI, this fix also works for D6 HEAD. I think I'll submit a patch for that as soon as my other patch lands.. :-)

I also have this problem in Amadou theme. Everything was working fine with Amadou one minute. Added Jstools and enabled some Ajax items. I didn't notice a change until days later when I attempted to edit a page and suddenly collapse doesn't work anymore for this theme only. I disabled Jstools and Ajax, but collapse still doesn't work. I deleted cache and cookies and closed browser and re-boot computer. Problem still exists and occurs for this theme now in both IE7 and FF 2.0.0.3. Both on XP home.

Drupalgirl

(This is a comment to #35)

In my setup (using newsportal), this works for Firefox, but causes a problem in IE: the grey horizontal rule now starts very close to the right hand end of the box rather than starting immediately after the link.

I actually couldn't find a "fieldset legend" in "system.css", so I just added one. Is there somewhere else I should be looking? Perhaps you could tell me exactly in which file you add this patch...

Thanks

David

Well, I urge everyone not to make core hacks - and that includes in css files. Try making all your changes in your theme css. Changing Garland - A Practical Example

OK, found a way of doing this in my module file ($answer in this example is the variable that holds the string that I'm building up to output as being the HTML served up by my module page):

// If Firefox, put in a hack to make collapsible fields work
if(false!=strpos($_SERVER['HTTP_USER_AGENT'],"Firefox"))
   {
         $answer.="<style type='text/css'>fieldset legend {display:block; }</style>";
   }

This puts in the display:block for Firefox but not for IE and seems to keep both browsers happy.

Yuck (but it works!)

- David

I've had this problem until i disabled Upload, Nice Menus and Nice Primary Menus modules. Then I enabled Upload and it's working right.

Considering the time elapsed between now and the last comment plus the fact that D5 is no longer supported, I am closing this ticket.