Amazon SES - co-maintainership request

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

I will report here a little checklist:

• The code needs to follow the coding standards; check in particular the format used for the control structures, and the name given to PHP variables, Drupal persistent variables, functions defined from the module.
• Files available from third-party sites should not be included within the module/theme. This is particularly true for files that are not licensed under GPL License v2, but it is also true for files that are licensed under the same license used by Drupal.
• The license file should not be included as well; the packaging script already include that file. In any cases, the code for modules/themes committed in drupal.org repository needs to be released under the same license used by Drupal; any compatible license is not allowed.
• Check the code passes the Coder validation.

As per requirements, the motivation message should include more than two sentences (the exact words are a few paragraphs) that describe the project features. For themes, it should include also a screenshot of the theme (at least 640x400 pixels), and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

Very interested in a module of this nature; also interested in how it might be backported to V6.

Given the integration between Amazon SES and PostFix, what advantages would a module offer over a pure pass-through implementation where Drupal addresses a mail UA like sendmail, and sendmail addresses Amazon SES? Would there be additional features and integration?

After reviewing this module, I see a few small items:

• Not all created variables are deleted in hook_uninstall (granted, there are many modules that don't, too).
• The module is automatically enabled as soon as it is installed. This is a problem because there are multiple steps that need to be configured with Amazon before it can be used.
• When sending an email, it doesn't verify that the site_mail value has been verified with SES before attempting to send mail, so the user has to deal with the Amazon error. Wouldn't it be more efficient to verify
  that in the module first?
• The Creeper module already takes care of the Amazon SES SDK, so why re-invent the wheel and not just use Creeper?
• There are still code formatting issues:
  • Spaces between parentheses and text contained in them.
  • Double the amount of space indentation (using 4, should be 2) in some places (such as ses_menu() and ses_permission()).

  I'm not sure why Coder didn't catch these (unless it just looks for minimum spacing, not too much).

Just noticed another user applying for CVS access with a similar module, maybe you could both work together http://drupal.org/node/1043276

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

It seems you are applying for two different users? Please chose the one you want to move forward with and close the other. They are not duplicates because they are two different user accounts. Thank you.

Hi @zugaldia. So, one person has to apply for the module, and then the other as co-maintainer. The co-maintainer process is very simple. We just need an issue in the project queue that states that someone should be a co-maintainer.

Since I am actually working right now on Ryan Palmer's application, I would just change the Component of this to a Co-maintainer application and change Project to Full Project, then create an issue to state that you should be co-maintainer.

Let me know if you have any questions.

I don't see the Amazon SES issue requesting co-maintainership ... I believe you should be able to post an issue in the Amazon SES queue requesting to be added as a co-maintainer, and have Ryan comment his approval ... no need to wait for Ryan to post the issue himself.

Also, I believe that project maintainers may now have the ability to grant commit access on their projects even without full co-maintainer status ...

In any case, as I don't foresee any further action occuring on this particular thread (assuming the co-maintainer steps are pursued in the actual Amazon SES queue), I'm going to set it to closed for now ... feel free to change it back if you'd rather leave this issue it open until the co-maintainership is resolved.