Added admin screens to maintain forums instead of forcing the user to add a taxonomy. In addition the patch hides the forum taxonomy from the categories screen since the forum module does not support all features of taxonomies.

The patch still needs clean up work for comments and the delete function needs to remove forum topics when you remove a forum, but I wanted to get it out for review.

This patch requires the latest forum speed up patch found here http://drupal.org/node/view/10308.

Craig

CommentFileSizeAuthor
#13 forumadmin6.patch20.65 KBwalkah
#12 forumadmin5.patch22.5 KBwalkah
#11 forumadmin4.patch22.04 KBwalkah
#6 forumadmin3.patch22.77 KBccourtne
#1 forumadmin2.patch22.84 KBccourtne
forumadmin.patch18.5 KBccourtne

Comments

ccourtne’s picture

ccourtne commented
StatusFileSize
new forumadmin2.patch22.84 KB

New patch that properly deletes forum topics when the forum is deleted, has all code comments, and updates the help text.

ccourtne’s picture

ccourtne commented

some screen shots of the admin screens
http://homepage.mac.com/ccourtne/drupal/forum_add_forum.png
http://homepage.mac.com/ccourtne/drupal/forum_add_forum.png
http://homepage.mac.com/ccourtne/drupal/forum_add_container.png
http://homepage.mac.com/ccourtne/drupal/forum_config.png

ccourtne’s picture

ccourtne commented

One more screenshot.

http://homepage.mac.com/ccourtne/drupal/forum_overview.png

ccourtne’s picture

ccourtne commented

updating to patch status

dries’s picture

dries commented

Looks good!

ccourtne’s picture

ccourtne commented
StatusFileSize
new forumadmin3.patch22.77 KB

Screenshots have a new home.

http://www.dawnsedge.com/ccourtne/drupal/forum_add_forum.png
http://www.dawnsedge.com/ccourtne/drupal/forum_overview.png
http://www.dawnsedge.com/ccourtne/drupal/forum_add_container.png
http://www.dawnsedge.com/ccourtne/drupal/forum_config.png

Also updated the patch for current CVS head.

walkah’s picture

walkah commented

not only do i think this looks very good, but i also think image.module folks should maybe take notice :) (hint hint).

oh, and weren't we gonna split taxonomy.module into taxonomy.inc + taxonomy.module at one point?

dries’s picture

dries commented

I'm going to commit as soon CVS HEAD is opened up for development. In the mean time, keep refining this patch so other modules can learn from it.

boris mann’s picture

boris mann commented

Is this going to get committed? Talk about it on CS developers list.

Also: can this separate multiple forums? Can it be extended to support multiple forums?

dries’s picture

dries commented

I'm afraid it does no longer apply. It's probably fairly easy to update though.

walkah’s picture

walkah commented
StatusFileSize
new forumadmin4.patch22.04 KB

updated patch. now applies to HEAD.

walkah’s picture

walkah commented
Assigned: ccourtne » walkah
StatusFileSize
new forumadmin5.patch22.5 KB

here's another slight update:

* fixes the updates.inc conflict
* some documentation / help cleanup
* fixed an inconsistency in 'forum' vs. 'forums' for the vocabulary module
* check for an existing forum vocabulary in _forum_get_vid, in case something happens to the variable.

walkah’s picture

walkah commented
StatusFileSize
new forumadmin6.patch20.65 KB

here we go again. fixing some typos, and help text. and making use of custom block settings and hook_settings.

dries’s picture

dries commented

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented