It would be great if it's possible for the Backups list to also display the filesize of each backup file

CommentFileSizeAuthor
#1 1042758-hostmaster.patch5.23 KBmig5
#1 1042758-provision.patch538 bytesmig5

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new 1042758-provision.patch538 bytes
new 1042758-hostmaster.patch5.23 KB

Patch for provision and hostmaster

Remember to run update.php to apply the database change.

Anonymous’s picture

Anonymous (not verified) commented

P.S I can't think of a good way to use hook_update() to fetch and update the file size of *existing* backups for existing users.

Because even though we store the filename in the database, the /var/aegir/backups dir is owned by the aegir user and the www-data user (executing the hook_update) can't stat the files inside it to get a filesize() of them.

So I think we'll just have to live with that, and people should probably rotate out old backups anyway. Besides, this isn't really crucial information, it's just nice to have.

realityloop’s picture

realityloop commented
Status: Needs review » Reviewed & tested by the community

agreed, we're still using betas anyway.. if it's working from 1.0 release then I think it's all gravy :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Fixed

Alrighty, committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 38659a5 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by mig5: 
    #1042758 - display filesize of backups

  • Commit 38659a5 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by mig5: 
    #1042758 - display filesize of backups