Add Content Folding Doesn't Work

Rob-

Can you report which browsers this fails on?

This bug actually comes from the core 'collapse.js' file and not from the MySite module.

It appears in both the 4.7.x and 5.x releases. For example, in Drupal 5 rc1:

// $Id: collapse.js,v 1.9 2006/12/10 09:05:47 unconed Exp $

lines 62-65:

      // Turn the legend into a clickable link and wrap the contents of the fieldset
      // in a div for easier animation
      var text = this.innerHTML;
      $(this).empty().append($('<a href="#">'+ text +'</a>').click(function() {

Please open an issue on the Drupal project, 'javascript' component, with specific details of the affected browsers. You may want to include this note (or a link to it) in your issue.

FF2 or FF1.5?

My dev machine uses FF 1.5 on a Mac, and I don't have this problem.

I think I misunderstood:

Hmmm, it works in IE7, but not in Mozilla Firefox. I'm not entirely sure why this is happening as the collapsible content works everywhere else.

You mean that the collapse functions work in other parts of Drupal but not on your MySite page? Like http://example.com/mysite/2/content?

I need more detail.

Which Drupal version are you using? There are significant changes between collapse.js 1.8 and 1.9 (1.9 is released with Drupal 5rc1). I've been testing against v 1.8 (drupal 5 beta 2).

Also check the generated page source for /mysite/2/content and be sure that the collapse.js file is being called. If it's not, we need to figure out why.

I just updated to Drupal 5rc1 and can't replicate this error (again, on Mac using FF 1.5).

Do the collapse elements work on mysite/2/view?

I just noticed that collapse.js is getting included twice on the Add/Remove Content page. Try commenting out line 129 of mysite.module:

  drupal_add_js('misc/collapse.js', 'core');

This might fix it on Add/Remove (and break it on View). If so, this means that the FormsAPI loads the collapse.js element, and I need to check for it's existence prior to loading it.

I think I've tracked this down. Try this:

Edit line 129 of mysite.module to:

  drupal_add_js('misc/collapse.js', 'module');

I think this will prevent the file from loading twice. if this fixes your problem, then the issue, is having two calls to the same .js file is confusing the browser.

I have committed this change to 5.x.1.dev, as I think it is an error in the use of http://api.drupal.org/api/HEAD/function/drupal_add_js.

If you can verify that the fix from #9 works for you, I'll mark this as closed.

Marking as fixed after no response.

This fix will go live with the next point release.