Login users who click the "Login now" button

Subscribing

Subscribing. May try and figure out some code... but I can't guarantee I'll be helpful.

What is the status of this Module ?

I managed to hack this module so it has the basic functionality [for my current project's needs]... Not sure if this is the right way to go about it, but thought i'd share a patch so somebody more knowledgeable can take a look.

I'm using this in tangent with the email_registration module..... don't... know... if that's.. important.. ; |

Here is a first attempt at actually implementing this:

* Attempts to login user if email address + password are provided
* Does most of the validation that Drupal core also performs (except flood login checking).
* Assigns the order to the user once login is successful

I might also implement extra functionality to optionally for the user to be logged in (although that might not really be best practice from a usability point of view), and try to find a way to make this work without Javascript.

I tried the patch in #5 and it works when the user write a proper password but when I put a invalid password I get this message back:

Notice: Undefined index: uid in commerce_checkout_login_checkout_form_submit() (line 94 of /Users/mattias/NetBeansProjects/mysite/sites/all/modules/commerce_checkout_login/commerce_checkout_login.module).

Thanks for testing the patch.
Does it break the desired functionality or not?

If a user can't be authenticated, the form submit shouldn't be called, so it should never arrive at line 94 :(
Did this happen when you clicked the "Login now" button, or the "Continue to next step" button?

I pressed the login button to get this error.

Subscribe

subscribe

when I've applyed the patch #5, I have an error "Notice: Undefined index: storage in commerce_checkout_login_checkout_form_submit() (line 95 of /sites/all/modules/commerce_checkout_login/commerce_checkout_login.module)." when a wrong password entered.

Hi looking at the code I think the problem is the use of #limit_validation_errors property. As I see here this makes the submition funcition run even the user input is not validated (even messages form form_set_error are not shown).

$form['account']['login']['login_now'] = array(
  '#type' => 'submit',
  '#value' => t('Login now'),
  '#limit_validation_errors' => array(), // HERE
  '#validate' => array('commerce_checkout_login_checkout_form_validate'),
  '#submit' => array('commerce_checkout_login_checkout_form_submit'),
);

EDIT: I've change that line to

'#limit_validation_errors' => array(array('account', 'login', 'password')),

and now is working for me. Going to test a little more.

Hey Ryan,

Is there anyway we can get a commit of this. I've done some extensive testing on it and it appears to work without problems.

Thanks

I attached a zip file of everything in #12. It's including the patch in 5 and a couple small changes to fix the error when the password is wrong.

I've tried it out, as is in the zip, and can't get it to error under many circumstances.

Here's a working patch. Sorry I was being lazy.

Line 50 & 78 code cleanup.

Patch #17 works.

patch in #17 works for me too