Hi, let me open the discussion on this, hoping that Ian takes this into consideration. Now that mailhandler branches 1.x and 2.x are being more and more different, I proppose that mailcomment 2.x branch keeps being with mailhandler 2.x, and let the current mailcomment 1.x branch merge smoothly into mailhandler module. I'll explain the reasons below.

For those not interested in having a full notifications platform (that includes one of my customers, so let's say, me also) I'd love to still be able to submit comments and nodes using old-fashioned email style, something that can be considered as 'low configuration effort'. As long as mailhandler (and I'm talking about 1.x branch) is able to post nodes and comments, the only reason why mailcomment is required is to make comments sync effort-less with the Drupal site. That could be an easy task to integrate into mailhandler 7.x.1.x, removing the dependancy of two modules, and still keeping the mailhandler module clean and small. The result is mailhandler being able to recieve emails and submit comments and nodes (as it says it DOES actually), so the module's purpose has no special change.

There are other technical reasons that I can brief, e.g., currently authorization/authentication in mailhandler are being done in the 'retrieve' file of the module, and contribs like mailcomment are still looking for this function making module_load_include() calls everywhere. Also, it makes harder to keep mailhandler module code clean as long as it requires keeping backward compatibility functions here and there, forcing new valid functions to have different names. Mailhandler module requires some love, and that cleanup (besides the 2.x branch) can happend for the Drupal 7 release. Module hooks are not pretty well documented, and broken depending on the context they are being executed (user interface or cron, because of the patch processing). Than can't be done when several modules around are using mailhandler old functions.

About the integration result, most of the code can be shared: mailbox access, message retrieval and parsing, error checking, authentication.. the only differences between mailhandler and mailcomment is that mailcomment allows automatic content placement. Currently mailhandler can do that, not automatically, so the only addition to mailhandler module will be the automatic email tagging on submission and correct interpretation on recieve processes, not a big deal however.

What do think? should we go for mailhandler 7.x.1.x being able to handle comments without messages framework as a requirement?

Comments

danepowell’s picture

Status: Active » Closed (won't fix)

6.x-1.x is no longer supported, please try a newer branch and re-open if still an issue. Thanks!