The jQuery selector only matches http:// links and not https:// links. I don't know if this is intentional or not but I've included a patch to add https:// link detection.

CommentFileSizeAuthor
#7 external-https-links-1043324-5.patch643 byteslikewhoa
#5 external.patch655 bytesreswild
external.patch525 bytesmjpa

Comments

alexkb’s picture

alexkb commented

Works great mjpa - thanks! Hope this gets committed to HEAD soon.

rjbrown99’s picture

rjbrown99 commented
Status: Active » Needs review

Changing status

papagrande’s picture

papagrande
Primary language English
commented

Works for me too. Thanks, mjpa .

likewhoa’s picture

likewhoa commented
Status: Needs review » Needs work

please provide a patch against master branch and i will be happy to apply.

reswild’s picture

reswild commented
Status: Needs work » Needs review
StatusFileSize
new external_1.patch655 bytes

Here is this patch against the master branch.

khalor’s picture

khalor commented
Version: 6.x-1.9 » 7.x-1.x-dev
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

All seems to be working...

likewhoa’s picture

likewhoa commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new external-https-links-1043324-5.patch643 bytes

rerollin old lost patch... thanks #5!

jordanmagnuson’s picture

jordanmagnuson commented

#7 works great. Thanks!

jordanmagnuson’s picture

jordanmagnuson commented
Status: Needs review » Reviewed & tested by the community
nehajyoti’s picture

nehajyoti commented

Have not tested the patch, but since the patch looks good & has been tested by the community and is in RTBC state, applying the patch.

  • nehajyoti committed 0f1583d on 7.x-1.x authored by likewhoa 
    Issue #1043324 by likewhoa, mjpa, reswild, JordanMagnuson, rjbrown99,...
nehajyoti’s picture

nehajyoti commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.