E.g.: http://git-dev.drupalcode.org/project/languageicons.git/commit/7d632b7dc...

It should be Frederik "Freso" S. Olesen, while it is shown as Frederik \Freso\" S. Olesen". So something somewhere messes this up. :)

CommentFileSizeAuthor
#5 1043410-05-fix_name_formatting.patch636 bytesFreso

Comments

Freso’s picture

Freso commented
Title: Committer names with quotes are badly escaped (Gitweb) » Committer names with quotes are badly escaped

Not just a Gitweb issue. Cloning through SSH has the same error in the logs.

Freso’s picture

Freso commented

This link should be a bit more permanent for showing the issue: http://git-dev.drupalcode.org/project/languageicons.git

sdboyer’s picture

sdboyer commented
Issue tags: +git phase 2, +git sprint 10, +tggm repo consistency

quick tagging

sdboyer’s picture

sdboyer commented

This is the literal output line generated by the cvsmigration module's csv drush output (email sanitized):

"27504","Frederik \"Freso\" S. Olesen","freso","SANITIZED@SANITI.ZED"

My guess is that it's probably a difference in how python's csv parsing works that's looking for some other kind of escaping, or some such, as it's python that's picking up the data and slapping it into place. Which means the line you want to look at is this one: https://github.com/sdboyer/drupalorg-git/blob/import-all-staging/cvs2git...

To the totally-non-python-expert eye, that seems like it should be working.

Freso’s picture

Freso commented
Status: Active » Needs review
StatusFileSize
new 1043410-05-fix_name_formatting.patch636 bytes

This should fix it. At least at the CSV->cvs2git step.

Another approach (which won't break the 80 char/line guideline) could be like so:

csv.register_dialect('drupalorg', delimiter=',', escapechar='\\', quotechar='"')

author_transforms = {}
cvsReader = csv.reader(open('csv-test-file', 'rb'), 'drupalorg')
Freso’s picture

Freso commented

This should be fixed once the cvs2git is run after sdboyer has pulled https://github.com/sdboyer/drupalorg-git/pull/14 :)

sdboyer’s picture

sdboyer commented
Status: Needs review » Fixed

Pull request has been merged in, this is all set now. Should show up in the next build.

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 10, -tggm repo consistency

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git phase 2, +git sprint 10, +tggm repo consistency

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.