E.g.: http://git.drupalcode.org/project/languageicons.git/commit/d750f95f0105d...

It would probably be more helpful with either a "normal" 404 or a helpful message that the commit doesn't exist.

Comments

Freso’s picture

Project: The Great Git Migration » Git on Drupal.org
Component: Migration scripts » User interface

I guess this should actually have been filed here. :)

http://git-dev.drupalcode.org/project/languageicons.git/commit/d750f95f0...

Freso’s picture

Title: Gitweb: Trying to see a non-existant commit yiels a 500 Internal Server Error » Gitweb: Trying to see a non-existant commit yields a 500 Internal Server Error
eliza411’s picture

Component: User interface » Gitweb Repo Viewer

Yep. I even added a component to track gitweb issues. Thanks.

eliza411’s picture

Were you adjusting URLs to see what happens or was there something in the interface that led you to a non-existent commit?

Freso’s picture

Adjusting URLs. The quick perceptionist will see that the commit hash for the two links I've posted here are the same, even if they're in different projects. It is also why I have marked this as minor and feat. req. :)

eliza411’s picture

I only saw one link, repeated. I wanted to be sure I was providing the team with accurate steps to reproduce the issue and that we had it in perspective for prioritizing.

neclimdul’s picture

Yeah, its actually more of a bug in gitweb's caching. I've looked over this in the past and didn't find it important enough to spend a lot of time on. Basically from poking around it looked like after the cache rendering takes over if it turns out the hash isn't valid, then it doesn't know what to do and returns nothing. Apache doesn't know what happened to the cgi so it returns a 500 Internal Server Error.

eliza411’s picture

Status: Active » Postponed

This isn't going to make it in before launch.

drumm’s picture

500 instead of 404 also happens on non-existant files, like http://drupalcode.org/project/api_dev.git/blob_plain/6.x-1.x:/drupal-org....

drupalorg's project_verify_package module verifies drupal-org.make by getting it from drupalcode.org.

drumm’s picture

Title: Gitweb: Trying to see a non-existant commit yields a 500 Internal Server Error » Gitweb: Trying to see a non-existant commit or file yields a 500 Internal Server Error