Needs work
Project:
Sky
Version:
7.x-1.4
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Jan 2011 at 17:22 UTC
Updated:
3 Feb 2012 at 18:41 UTC
There is a problem with page.tpl.php with the secondary tabs not showing in the JS overlays. For example, in webform and Media module.
I changed the tabs code from:
<?php if (!empty($tabs['#primary'])): ?>
<div class="tabs"><?php print render($tabs); ?></div>
<?php endif; ?>
To:
<?php if (!empty($tabs['#primary']) || !empty($tabs['#secondary'])): ?>
<div class="tabs"><?php print render($tabs); ?></div>
<?php endif; ?>
Comments
Comment #1
jacineThanks for this report. I'm already aware of this problem, which is related to this core bug: #953034: [meta] Themes improperly check renderable arrays when determining visibility. It will likely need to be
<?php if ($tabs = render($tabs)): ?>, though I'd like to wait a little while and see what pans out there.Comment #2
Amarjit commentedAh yes, thanks.
Comment #3
jacineA fix has been committed, and will be released shortly. Thank you! :)
Comment #5
TelFiRE commentedIt's been a year and was never committed?