A new topic with no comments does not show new post icon

I confirmed the bug but don't agree with the solution. I'll dig into this and get it fixed. Thanks for reporting.

Michelle

PS: It's really not necessary to add tons of tags to things. Tags are only needed if you need to make a group of issues, like the set of issues I need to fix before alpha 4. :)

Well, the function returns how many new replies there are, so returning 1 new reply when there are no replies but rather an unread starting node doesn't make sense. I checked here on drupal.org and core gets this right so I've been looking at core's code and my code and have some concern about the performance of using this function to control the icon at all and adding an extra query would only add to that. So basically you uncovered a missed symptom of what is potentially a deeper problem and I want to take some time and investigate a better solution to commit to the module.

Michelle

I got a similar problem:

If there is an old topic, but a new comment, on the board overview page, there is no visual sign, that corresponds to that.

@balabushka: That's unrelated. Just turn the option on in settings.

Michelle

Gracias! Tbh, the german translation is so bad and incomplete, it was not clear for me!

Well, we aren't even in beta, yet, and the strings are far from frozen. I wouldn't expect whoever is translating it to put much time into it yet.

Michelle

sub

Requesting this be pushed to alpha 5, since we have lots of features fully implemented in -dev that aren't in alpha 3 and this isn't close yet.

This isn't a feature; it's a bug. So, no, it's not being pushed off.

Michelle

Yeah, but doesn't core forum behave the same way? If you really want to wait until every little misbehavior is fixed, we'll never release anything. I think the proposed behavior makes more sense, but the old behavior is consistent and it's important to get something out there.

No, core doesn't have this bug. And, as I said in #4, I have a feeling this is a symptom of a deeper problem. I need to take the time to dig through that old code and make sure I'm not doing something stupid there like I suspect I might be.

I'm not in a rush to release. I'd like to get a new alpha out just to get people to stop using Alpha 3 but this isn't a race. Doing it right is more important than doing it fast.

Michelle

Sorry, rcurtin, I've been really bogged down in another blocker issue that sucked up a good chunk of my last week so haven't been able to dig into this yet. I appreciate the offer but it's not so much that your patch is bad but that it's putting a bandage on a festering wound. I haven't looked at the code in depth, yet, so I could be wrong but I think there's some refactoring needed in there because I don't think I did a good job of it the first time around.

Soon as I get that other issue done, I'll be turning my attention here and getting this fixed up.

Michelle

Test

@rcurtin: Just to mention, with Michelle being busy for a little while (see note on the project page), it would help the project a great deal if you could give writing an updated patch a try.

When I wrote my response in January, I wanted to do it right, not just bandaid it. Given that it is now March and I'm looking at doing a release without this fixed, I'm more responsive to temporary solutions. If you can get me something that's working with the current dev in the next day or so, I'll get it in and save the deeper look until I get back to AF sometime in late April / early May.

Michelle

@rcurtin: no disrespect was intended, I hadn't read the full discussion so was unaware you were waiting on Michelle.

I just meant re-rolling against the latest dev since the patch no longer applies.

Michelle

Ok, I committed the patch and also made this change in theme.inc:

  // Link to first new post only if the new post isn't the topic starter.
  $variables['first_new_post_link'] = '';
  if ($posts > 1) {
    $variables['first_new_post_link'] = advanced_forum_first_new_post_link($variables['node'], $variables['comment_count']);
  }

Otherwise the header of a new topic had a link to the first new post that was broken since there was no comment ID to link to. I was going to just fix the link but realized having the link there at all was pretty silly in this case.

Sending this over to troky for D7 and then it can be marked fixed. I'm going to start a new issue for the underlying problem rather than totally change this one.

Michelle

Forgot to detag and also say thanks for the help and patience. :)

Michelle

Done.