Hello,

I've tried on two different D7.0 sites, and there is no configuration for a Tetris block. I've also noticed that the tetris-7.x-1.7.tar.gz does not include a install file (tetris.install).

Best regards,
Ao

CommentFileSizeAuthor
#27 tetris.tar_.gz36.83 KBAonoa
#23 23_tetris.patch1.73 KBAonoa
#22 4075697_tetris.patch1.74 KBAonoa
#21 tetris.patch1.45 KBAonoa

Comments

skinhat’s picture

skinhat commented

I've added some more info on

http://drupal.org/project/tetris

that might make it clearer on how to make it visible.

Aonoa’s picture

Aonoa commented

I guess I should have written a more detailed description. In the structures/blocks menu is where the block is missing from. There is no disabled tetris block I can enable.

Best regards,
Ao

skinhat’s picture

skinhat commented

Do you see 'Tetris Configuration' in the admin menu?

Aonoa’s picture

Aonoa commented

Yes, that is present. Leaving the default values in place and clicking save does not make the tetris block appear in the blocks configuration either.

Best regards,
Ao

skinhat’s picture

skinhat commented

What happens if you disable the tetris module and then reenable it? Does it appear in the structures blocks menu after that?

Aonoa’s picture

Aonoa commented

No change at all, I'm afraid. I tried to clear the cache too and there are no errors logged.

Best regards,
Ao

skinhat’s picture

skinhat commented

I'll see if I can get a second Drupal 7 environment and see if the problem you're having is reproducible. I'm wondering if other people are having the same problem.

Aonoa’s picture

Aonoa commented

Just for the sake of testing, I built a new D7.0 site from scratch with the default profile and enabling Tetris was the first thing I did afterwards. The "Tetris Configuration" setting appeared the same as last time, but the tetris block is still missing from "structure/blocks".

Best regards,
Ao

ThumbsUpDavid’s picture

ThumbsUpDavid commented

Hello,

I'm also not generating a Tetris block upon activation.

skinhat’s picture

skinhat commented

Ok, Ive hidden the release until I discover the problem as looks like a second person has the same problem. Have no idea what the problem is.

ThumbsUpDavid’s picture

ThumbsUpDavid commented

I'd also like to note that I didn't even get the "Configuration" link. It was enabled and installed (as far as I know), but no Configuration link showed up, and there was no block, either.

skinhat’s picture

skinhat commented

Its odd theres different behaviour for the tetris module on different systems as the tetris module works fine for me using the latest version of Drupal 7.

Aonoa’s picture

Aonoa commented

I am using the latest stable release of drupal as well. The 7.0 release. Are you using any other modules on that system?

Best regards,
Ao

skinhat’s picture

skinhat commented

No, just tetris.

http://smokers.skinhat.com/

Aonoa’s picture

Aonoa commented

Could PHP or Apache configurations affect anything? You did a new install of Drupal 7.0 without any odd patches?

Best regards,
Ao

skinhat’s picture

skinhat commented

No, just Drupal by itself.

Aonoa’s picture

Aonoa commented

Just for the heck of it, I disabled and re-enabled the module many times just now and still nothing.

For your site http://smokers.skinhat.com/, did you use the tetris-7.x-1.7.tar.gz archive? I mean the exact same file, downloading it and using it from this site.

Best regards,
Ao

skinhat’s picture

skinhat commented

Yes

Aonoa’s picture

Aonoa commented

Any progress? I'll ask again about a tetris.install file, which is not included in the tar.gz package, I thought all modules should have this?

Best regards,
Ao

Aonoa’s picture

Aonoa commented

Looking at tetris.module, should there not be a hook_block_info() function and hook_block_view() function in there?

Best regards,
Ao

Aonoa’s picture

Aonoa commented
StatusFileSize
new tetris.patch1.45 KB

I managed to fix it, not sure if it's a good fix or not but it works for me.

Best regards,
Ao

Aonoa’s picture

Aonoa commented
StatusFileSize
new 4075697_tetris.patch1.74 KB

A revised patch, also fixing an undefined index notice in tetris_win().

Best regards,
Ao

Aonoa’s picture

Aonoa commented
StatusFileSize
new 23_tetris.patch1.73 KB

Another little tweak.. sorry about the patch spam here. :-)

Best regards,
Ao

Aonoa’s picture

Aonoa commented

How very odd, the block is gone again.. I think after clearing my cache.

Best regards,
Ao

Aonoa’s picture

Aonoa commented

Disregard my comment in #24, it was merely because I had multiple tetris folders in my modules directory and it used the unpatched version.

Best regards,
Ao

skinhat’s picture

skinhat commented

Do you have the full module code? I dont know how to use patches. Looked at

http://drupal.org/node/60108

and says for Windows need to install Eclipse which dont want to do.

Aonoa’s picture

Aonoa commented
StatusFileSize
new tetris.tar_.gz36.83 KB

Aha, sure.

Best regards,
Ao

skinhat’s picture

skinhat commented

Ok, have added your change and made a new release. Hopefully your change will make it work for other people.
Thanks.