Closed (fixed)
Project:
Taxonomy Access Control Lite
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
20 Dec 2006 at 15:15 UTC
Updated:
30 Jan 2007 at 03:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
PRZ commentedIn any case, I do hope yogadex is planning the 5.0 version. This is an important module needed for 5.0!
Comment #2
Dave Cohen commentedI'm planning to support this in 5.0. It's next on my list, but I haven't had time to learn about the node_access changes in 5.0 yet.
To summarize the module: it allows users to see nodes based on the terms associated with the nodes. Similar to Taxonomy Access Control, but that module was complicated far beyond my needs, and didn't support grants on a per-user basis. So TAC lite is simple in that it concerns itself only with read grants (not update) and it allows grants per-user. Later, I added grants per-role and it was easy to add. I don't plan to split that into another module, as I don't think it's justified.
Comment #3
PRZ commentedHi, yogadex.
Again, thanks for all your work on this module... it is really one of the most valuable of all modules to me.
Not to be a bother, but do you have any estimate on when you might have a version for 5.0 that I could help test?
Thanks again and Happy New Year! Paul.
Comment #4
Dave Cohen commentedThe attached patch should make the HEAD version of tac_lite work with the HEAD version of drupal (which I believe is version 5).
Please apply this patch and let me know if there are any problems.
Comment #5
PRZ commentedAm trying this new version on my 5.0 RC1 installation. I patched the head version of tac_lite, but so far just have the white-screen-of-death when trying to enable in Drupal 5.
I created a tac_lite.info but did not change the tac_lite.install file.
I'll look over the patched .module and .install files to see if I can see the problem...
Comment #6
PRZ commentedI repatched the file and reinstalled successfully. (My previous error was from an ftp permissions issue, not the patch file.)
I'll be testing today and f/u with a report later.
Comment #7
PRZ commentedI've installed onto a 5.0 RC1 test site. I also have installed the latest dev builds of CCK, views, contemplate, front, poormanscron, and devel.
I tested tac_lite on some new page content nodes setting up a test 'Privacy' vocabularly with a few terms. My results are:
Comment #8
Dave Cohen commentedI now understand why this is happening. I will try to post a fix here later today or tomorrow.
I don't know why a CCK node would behave any differently from any other node. Please install the devel_node_access module (which comes with the devel module). Then if there is a problem controlling access to CCK nodes, post a seperate issue and include what the devel_node_access module reports.
Comment #9
Sophia commentedI hope I am at the right place... I read the information on the patch, downloaded but I am not sure what to do with it, can anybody please help? I am slowly upgrading my site to version 5 and this is one of the modules that needs upgrading. Thanks!
Comment #10
Dave Cohen commentedHere's an updated patch that includes an updated method in tac_lite.install. This will update the node_access table so that nodes with no privacy terms will remain visible to the public. So to test this, first apply the patch, then run update.php, then confirm that the access permissions are correct.
Sophia, to test this, you have to get the latest cvs head version of the module, then apply the patch file. If you search for 'how to apply patch' on drupal.org you should find directions. If its too complicated, wait until this issue is fixed then the latest downloadable version will work.
Comment #11
Tobias Maier commentedsubscirbe
please dont change anything of the issue, like priority, category or title if not needed
Comment #12
Deyan commentedHi,
I just installed the module, patched it successfully, but when I try to enable the module from administer modules I get
Fatal error: Call to undefined function: update_sql() in /home/ivo/public_html/drupal5/modules/tac_lite/tac_lite.install on line 18
Comment #13
PRZ commentedyogadex,
Your latest patch seems to have fixed the previous issue and nodes with no privacy terms do remain visible to the public now.
I also reinstalled CCK with latest build and had no problems with tac_lite controlling access.
So, for now, tac_lite for drupal 5.0 RC1 seems to work as advertised... thanks!
Comment #14
Dave Cohen commentedThis updated patch should fix the illegal update_sql call described by Deyan.
Also, includes a call to automatically rebuild the node_access table when module settings are changed.
Comment #15
kahennig commentedHi,
first of all, thanks for all your work yogadex! I am new to Drupal and had been playing with taxonomy because I could not find a tac_lite for 5.0.
Since finding this thread I tried the second patch and got the update_sql() error, returned here and you had already posted another patch. Now I patched HEAD with the latest diff and tac_lite is working. I don't have time right now to do a complete test, but at least it installs and seams to be showing up in access control and some other places. The days is over for me and I'm going home.
Tomorrow I will try to follow your screencast and set the whole thing up. I'll let you know how it turns out.
Comment #16
Deyan commentedThanks Yogadex, it installed with no problem now and seems to be working! :)
Comment #17
Dave Cohen commentedChanges checked in and created a DRUPAL-5 branch.
Comment #18
kahennig commentedOK, so far so good. I said that I'd report back and I have not had any issues with tac_lite for Drupal 5 yet.
Thanks again for you work.
Comment #19
nategasser commentedThis looks to be exactly what I need with one exception. Is there a way that nodes not specifically tagged can return access denied?
In other words, I want to GRANT access to nodes on my site, not RESTRICT them.
If it's here and I'm not doing it right please let me know. If it would need to be added I'd consider doing it but wanted to check first. Obviously would be nice as an option.
Thanks!
Comment #20
Dave Cohen commentedNate, your question is off topic for this issue. This issue will disappear once it's closed, so whatever wisdom is imparted here will be lost to the world. So next time its better to start a new topic in the forums.
Anyway, my suggestion would be to use a taxonomy to control privacy, and make that taxonomy required. That way when you add a node you'll have to select a privacy term.
Comment #21
(not verified) commented