Closed (fixed)
Project:
Office Hours
Version:
6.x-1.0
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Jan 2011 at 16:30 UTC
Updated:
12 Jun 2012 at 19:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
johnvIndeed, in the settings form the start hours are not saved correctly, and have the same value as the end hours.
Comment #2
johnvUpdating title. More issues report having problems with this field.
Comment #3
ntg commentedAny updates on this bug?
Comment #4
johnvCan't find the cause of this weird problem. Any patches are welcome.
Comment #5
Ozeuss commentedFor some reason we've used 'office_hours_select' as an element, but it doesn't really make sense because limiting hours concerns hours and not minutes and you can't decide which time format to use - so I've reverted to using a simple select box and using both.
A patch is supplied, please test, seems to work for me.
Comment #6
johnvThis is a very nice piece of work! Enabling the not-allowed hours is a good thing.
It has one drawback, a per the next example:
- edit a node, set the hours to 9-17
- set the allowed values to 10-18
- edit the node again, the invalid hours are now empty, without showing a warning.
I could not apply your patch. Then I noticed that it was already committed to 6.x-1.x, so I am correcting the status.
Comment #7
johnvAnd attached patch corrects some trailing spaces and code styling (no return + break).
Comment #8
johnvAlso committed.