When dropping an image on the Facebook button
http://www.facebook.com/sharer.php?u=
opens in a full browser window.
I think it's meant as a popup judging the button locations.

And the new 'Facebook' way seems to be to share through the JS API.
http://stackoverflow.com/questions/376763/is-there-a-share-this-for-face...

Including the necesary facebook javascript is easy with the Drupal FB module:
http://drupal.org/project/fb

So maybe it would be cool like this:
if the FB module is not installed it uses the old sharer.php?u=
with content in a smaller dialog instead fullscreen, if possible with the faded background (lightbox style).
And when the FB module is installed it uses the JS API.

I can try to make a patch.

Comments

silkogelman’s picture

silkogelman commented

Ugly browser popup way for OLD Facebook share style is here
http://www.bloganol.com/2008/08/add-share-on-facebook-link-and-buttons-o...
But we better put it in as lightbox style.

shaman365’s picture

shaman365 commented

Yes! That would be very nice. I just intsalled this and its perfect for what I need. The smaller facebook dialog popup would be money if you can swing it.

Thanks for this awesome module.

silkogelman’s picture

silkogelman commented
Assigned: Unassigned » silkogelman

I'm working on an implementation that checks if the FB module is installed and uses Facebooks Feed dialog (only when FB module is installed), so it leaves it as is when not enabled.

and maybe jquery_ui.dialog is a nice solution for the 'old' Facebook sharer.php case (when FB module is not installed).

FB module check was easy, I added
'fbmodule' => module_exists('fb'),
to the array drag_to_share for drupal_add_js, so we can do stuff with that in the js.

Facebooks Feed dialog is also no problem.

The biggest problem is that if I add a simple if statement after
else if (id.indexOf("facebook") != -1) {
when dropping the image on the target the whole thing freezes.
I can't even get it to do a simple 'if true then x'.
It must be something simple I'm not seeing now.

shaman365’s picture

shaman365 commented

It sounds like that statement may be executing infinitely or something on the hover/release state. Wish I could be of more help. Sounds like you're almost there though.

silkogelman’s picture

silkogelman commented
Assigned: silkogelman » Unassigned
Status: Active » Postponed

I gave it another shot, but it seems the drag to share javascript needs some rewriting before I can implement the Facebook script part. I am not a javascript / jQuery king, It would take me too much time, so I give up.

raulmuroc’s picture

raulmuroc commented
Issue summary: View changes
Status: Postponed » Closed (won't fix)