My feeds weren't validating with the Feed Validator, causing a large social networking site to fix ignore a bug report I submitted.

The attached patch fixes the tiny problem, allowing the feeds to validate correctly.

Be gentle: it's my first patch.

CommentFileSizeAuthor
#1 rssvalidate_0.patch1.2 KBChrisKennedy
rssvalidate.patch1.13 KBcoreb

Comments

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new rssvalidate_0.patch1.2 KB

Confirmed bug and that patch corrects the error - per http://blogs.law.harvard.edu/tech/rss#ltguidgtSubelementOfLtitemgt the value of guid's isPermaLink attribute should be 'true' or 'false', not FALSE. Re-rolled against HEAD and from the root directory.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

ChrisKennedy’s picture

ChrisKennedy commented

Btw, this was originally implemented correctly by http://drupal.org/node/38593 but http://drupal.org/node/72204 incorrectly changed the output capitalization FALSE.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)