#1028876: Future of ImageMagick toolkit

CommentFileSizeAuthor
#12 imagemagick-HEAD.12.migrate.patch2.13 KBsun
#11 imagemagick-HEAD.11.migrate-vars.patch1.11 KBsun
#10 1045454-vars.patch987 bytesandypost
#9 imagemagick-HEAD.9.uninstall.patch2.16 KBsun
#8 imagemagick-HEAD.8.rotate-debug.patch2.93 KBsun
#7 imagemagick-HEAD.7.final_.patch3.39 KBsun
#6 imagemagick-HEAD.6.patch2.61 KBsun
#5 imagemagick-HEAD.5.coding-standards.patch10.23 KBsun
#4 imagemagick-HEAD.3.core-sync.patch8.22 KBsun
#2 imagemagick-HEAD.2.toolkit-config.patch7 KBsun
#1 imagemagick-HEAD.1.patch9.88 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs work
StatusFileSize
new imagemagick-HEAD.1.patch9.88 KB

Committed attached patch, which simply moves + renames functions from imageapi_imagemagick.module.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new imagemagick-HEAD.2.toolkit-config.patch7 KB

Committed attached patch, which updates the ImageMagick image toolkit configuration for D7.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I'm testiing and fixing related code

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new imagemagick-HEAD.3.core-sync.patch8.22 KB

Committed attached patch, which synchronizes order of functions and phpDoc with Drupal core's GD toolkit.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new imagemagick-HEAD.5.coding-standards.patch10.23 KB

Committed attached patch, which fixes various coding standards issues.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new imagemagick-HEAD.6.patch2.61 KB

This patch makes it work. Not sure whether it is the correct way for ImageMagick.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed
StatusFileSize
new imagemagick-HEAD.7.final_.patch3.39 KB

Thanks for reporting, reviewing, and testing! Committed attached patch to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new imagemagick-HEAD.8.rotate-debug.patch2.93 KB

Additionally fixed the rotate action and debug output. Could use some unit tests, but I'm not up for that.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new imagemagick-HEAD.9.uninstall.patch2.16 KB

And lastly... fixed missing uninstall hook ;-)

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 1045454-vars.patch987 bytes

variables migration patch

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new imagemagick-HEAD.11.migrate-vars.patch1.11 KB

Thanks for reporting, reviewing, and testing! Committed attached patch to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Fixed » Needs review
StatusFileSize
new imagemagick-HEAD.12.migrate.patch2.13 KB

ok, the ImageAPI migration code was a bit stupid... of course, the module update for imagemagick module is not executed when installing the module, so this migration path is never executed.

Attached patch should fix the problem. Could use another review.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed to master.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.