There's really no reason that one wouldn't want to BOTH react to scripts and run log fetches on cron. We don't need it on d.o, but it's still quite legit. Consequently, the way that VersioncontrolRepository::update_method works right now is stupid, or at least the way we describe how it works (and present options on the repo editing page) is stupid. There should just be a simple flag indicating whether to fetch logs on cron, and a checkbox for it. There's no reason for it to be any more complicated than that.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1045742-cron-as-flag-D6-3.patch | 16.94 KB | marvil07 |
| #2 | 1045742-cron-as-flag-2.patch | 23.52 KB | marvil07 |
Comments
Comment #1
sdboyer commentedi would actually like to have this done for release. here's what's needed
{versioncontrol_repositories}.update_methodto{versioncontrol_repositories}.cron, which is 1 if it should run on cron and 0 if nothook_cron()in versioncontrol.module and have it do basically exactly what's done inversioncontrol_git_cron()right nowComment #2
marvil07 commentedI think this patch does it:
Let's see what bot thinks.
PS: I have two commits locally for this patch to differentiate views re-export change.
Comment #3
marvil07 commentedLast patch added to 7.x-1.x
I reworked the change for 6.x-2.x as in the patch an added it.
Copying conflict section from commit message: