Closed (fixed)
Project:
PhpGedView
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Dec 2006 at 05:10 UTC
Updated:
11 Jan 2007 at 19:15 UTC
I would like to have an option to have pgv open outside the Iframe.
Comments
Comment #1
karens commentedSo would I, but I haven't found any way that it will work. I investigated other problems that were integrating with PGV and *all* of them do it in an iframe. There are too many problems to list, but basically PGV is designed as a stand-alone program that will only work if called from within its own directory, plus it starts its own session, which interferes with the session that Drupal started, etc etc. I tried and tried to find a way and finally gave up.
If someone finds a way it will work I'll gladly work it in, but I can't spend any more time trying to find it myself, at least in the near future.
Comment #2
karens commentedOops, I may have misunderstood your request. The embedded version must be in an iframe, but maybe you mean you want a link to open it in its own window outside the iframe? That would be easy enough.
Comment #3
spankee commentedI would rather not have it open in an Iframe at all. just have it pop up outside of Drupal all together. If it is inside an Iframe the search engines will not link to my information correctly.
There is one integration that does not require an Iframe. Have a look here http://dev.xoops.org/modules/xfmod/project/?pgvxoops
However, there were a lot of conflicts with js and css.
Comment #4
karens commentedThat xoops module is actually done by embedding the entire PGV program inside the xoops module, then rewriting a number of PGV programs. In other words, it is a fork of PGV that is heavily modified and that would need to be maintained to be sure it stays in synch with the original PGV program. There are a number of reasons why this method won't work for a Drupal module:
1) Drupal's policy is not to include external programs in Drupal's cvs system, so we can't just pick up the PGV program and drop it in the Drupal project in the first place.
2) Even if Drupal policy allowed this, the PGV program changes frequently, and and to maintain this fork, someone would have to monitor all those changes and be sure to add them to the code in the Drupal module, not something I have the time or interest to do.
It illustrates what I said earlier -- there really is no way to embed this except by using an iframe (which allows the original code to function as it normally does without hacking it)
Comment #5
spankee commentedI was just letting you know that there was one integration not using an Iframe.
All I want is just a basic user integration. I do not want Pgv framed by Drupal. They should be displayed as two seperate programs. The links get messed up when displayed inside an iframe and do not get indexed properly by the search engines.
Comment #6
karens commentedAnd I was just letting you know that wasn't going to work :-)
Anyway, your point about an option to link to the external application instead of embedding it is valid. I made some changes and just committed them. I don't have the instructions updated yet, but go to the phpgedview settings page in Drupal and where it asks for the embedded path, make that option blank. If it is blank, no embedded paths will be created and instead you will see a menu item that links to the external program. The external link should give the search engines a way to search through your files and the dual login should still work the same if you have mapped your users together.
I know there may still be other login issues that need to be reviewed, but that's another issue.
Comment #7
spankee commentedThanks for this new feature and all your hard work. I will try it out as soon as I can.
Patrick
Comment #8
(not verified) commented