As discussed a little in #1031588: Major error: white screen of death - the hex2rgb functions (of which there were at least 3 at one point) either got doubled up or went missing over time.
Decision - moving things into their own utility-color.inc type libraries had no advantage. It was an attempt at keeping the libraries lightweight and independant, but since then I've given that up and started typing them all together with a (do-nothing) imagecache_actions wrapper module that JUST holds the shared libraries. Reducing the dependency confusion I hope.
ANYWAY.
We need to
- get a working hex2rgba into utility.inc. named imagecache_actions_hex2rgba to avoid lazy namespace collisions (my lazyness years ago)
- remove the old one, update the code to the latest greatest.
- change any calls that are made to it.
Here goes.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | imagecache_actions-hex2rgb-1046200.patch | 8.41 KB | dman |
Comments
Comment #1
dman commentedI am not committing this immediately, as delays over at #818798: Drupal 7 version? may mean that other folk have progressed on a branched patch in the last week.
But if anyone who cares wants to say it's worth more to get this fixed, OR that there is nothing substantial in other threads that need merging, just RTBC this and I'll commit.
Comment #2
dman commentedCommitted and released
imagecache_actions 7.x-0.0