Drupal.Dialog.submitAjaxForm not correctly rewriting URLs [#1046758]

Comment	File	Size	Author
#7	dialog_1046758.patch	570 bytes	drewish
	dialog_urls.patch	931 bytes	drewish

Comment #1

dave reid

he/him

English

Nebraska USA

commented 31 January 2011 at 21:26

Status:

Active

» Needs work

+++ dialog.js	31 Jan 2011 21:19:36 -0000
@@ -108,11 +108,11 @@
-      url.replace('/nojs/', '/ajax/');
+      url = url.replace(/\/nojs(\/|$)/g, '/ajax$1')
 
       var ajaxOptions = {
         type: 'POST',

Needs to use /\/nojs(\/|$|\?|&|#)/g, '/ajax$1' to match D7 core's ajax.js.

Powered by Dreditor.

Log in or register to post comments

Comment #2

drewish commented 31 January 2011 at 21:36

But this issue is for D6...

Log in or register to post comments

Comment #3

drewish commented 2 February 2011 at 15:58

Version:	6.x-1.x-dev	» 7.x-1.x-dev
Status:	Needs work	» Patch (to be ported)

Committed to 6.x, kicking this over to 7.x for review. Make sure to look at Dave Reid's comment in #1.

Log in or register to post comments

Comment #4

dave reid

he/him

English

Nebraska USA

commented 2 February 2011 at 16:00

BTW, #1 is how ctools for D6 also uses it.

Log in or register to post comments

Comment #5

drewish commented 2 February 2011 at 17:03

Dave Reid, I think you might be mistaken. I just double checked and CTools DRUPAL-6--1 uses the regex I used in this path: http://drupalcode.org/viewvc/drupal/contributions/modules/ctools/js/ajax...

While searching around I came #970536: nojs/ajax replacement fails in various situations which backports the D7 version to D6. I like that it centralizes the regex into a function so I could call it.