Download & Extend
Double Click » Issues

Interferes with DHTML Menu

Posted by filiptc on December 21, 2006 at 9:43pm
Project:Double Click
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

Seems like some js code collides. Typically, using the DHTML Menu module, when you click on a collapsible menu item it opens/closes with dhtml without opening the linked node/page (i.e. 'administer').

After enabling this module this behavior is broken. Although the menu unfolds on click the link begins loading too.

Only seems to happen with firefox (2.0.0.1) opera (9.1) (for roles with access), while in IE (both 6 & 7) the double click module does not work (double clicks get recognized as single ones) and DHTML works fine.

I haven't had time to look into the core codes yet though but there's gotta be some js function/var that is in use in both modules... or something with jquery...? No clue.

Take a look.

Phil

Login or register to post comments

Comments

#1

Posted by Steve McKenzie on January 11, 2007 at 11:42pm

confirm this bug.

here's a fix.

i also added in some additional tweaks to the JS and how the dest var was handled.

AttachmentSize
dblclick_dhtml_menu_support.patch 2.76 KB

#2

Posted by Steve McKenzie on January 11, 2007 at 11:43pm
Status:active» needs review

#3

Posted by filiptc on January 12, 2007 at 3:03am
Status:needs review» needs work

Thx, but could you please make a patch for the latest HEAD.

#4

Posted by Steve McKenzie on January 14, 2007 at 5:20am
Status:needs work» needs review

ok.. sorry about that.

i see head has some nice changes too!

AttachmentSize
dblclick_dhtml_menu_support_0.patch 1.79 KB

#5

Posted by Steve McKenzie on January 14, 2007 at 5:23am

i added a comment to this patch.

AttachmentSize
dblclick_dhtml_menu_support_1.patch 1.86 KB

#6

Posted by filiptc on January 14, 2007 at 3:14pm
Status:needs review» reviewed & tested by the community

Awesome, finally :)

#7

Posted by Steve McKenzie on January 14, 2007 at 10:23pm

lol.

#8

Posted by Steve McKenzie on January 16, 2007 at 2:32am
Status:reviewed & tested by the community» fixed

jjeff committed this already.

#9

Posted by jjeff on January 16, 2007 at 12:19pm

You beat me to it, Steve!

Yes. Committed.

#10

Posted by Steve McKenzie on January 16, 2007 at 5:13pm
Status:fixed» closed (fixed)

hehe.

#11

Posted by seanberto on January 31, 2007 at 12:07am
Status:closed (fixed)» active

I just downloaded dblclick-5.x-1.x-dev.tar from Jan 17th and have tried it both with DHTML menus HEAD and the official release, dhtml_menu-5.x-0.7.

With FF2.0 and XP, I'm still having conflicts. Dblclick itself doesn't seem to work with dhtml_menu HEAD, and it's breaking the double-click feature of dhtlm_menu.

Understandable if this is a conflict you can't resolve. I would hate to have to choose between two great modules...

#12

Posted by jjeff on January 31, 2007 at 4:49pm

Yeah. I'm aware of the conflicts. I think something is going to need to change at the DHTML Menu end as well. This is going to requires some thought to coordinate. If anyone has ideas/patches, please let me know.

#13

Posted by Steve McKenzie on February 9, 2007 at 1:50am

http://drupal.org/node/117370

this will solve it as the dblclick() event is being removed from the module.

nobody click here