Error being thrown when trying to view invoice on admin interface ie /admin/store/orders/6
Fatal error: Unsupported operand types in /sites/all/modules/ubercart/payment/uc_payment/uc_payment_order_pane.inc on line 39

Only payment modules enabled are PayPal and BankTransfer

CommentFileSizeAuthor
#12 uc_paypal.module.nato_.patch534 bytesn8o
#8 uc_paypal.patch790 bytesMeriial

Comments

essbee’s picture

Status: Active » Closed (works as designed)

Appears to be caused by the Bank Transfer module. Will re-post in that queue

essbee’s picture

Status: Closed (works as designed) » Active

Still displaying this symptom. Not related to Bank Transfer. Only have uc_paypal and uc_payment enabled.
Cant see whats causing it.

longwave’s picture

Status: Active » Postponed (maintainer needs more info)

What payment methods were used in the affected orders, or does this happen on all orders? Haven't seen this in the brief testing I've done.

essbee’s picture

Happening on all orders, paypal is the only enabled payment method.

ndewhurst’s picture

Version: 7.x-3.x-dev » 7.x-3.0-beta1

encountered same issue. "edit order" link works w/o trouble.

Meriial’s picture

The problem is in uc_paypal.module, l. 532

return $build['#markup'] = t('Transaction ID:<br />@txn_id', array('@txn_id' => $txn_id));

will return the string, not the array. It should be something like:

$build['#markup'] = t('Transaction ID:<br />@txn_id', array('@txn_id' => $txn_id));
return $build;

I'm new to helping out. Should I make a patch?

tr’s picture

Status: Postponed (maintainer needs more info) » Active

@Meriial: Yes, it would be great if you can make a patch, preferably against 7.x-3.x-dev. That way people who experience this issue can test the *exact* changes you're proposing and verify the patch fixes that issue (and doesn't cause any others either!). See http://drupal.org/patch/create to see how it's done, if you don't already know.

Meriial’s picture

StatusFileSize
new790 bytes

OK, here's my patch, done against a CVS checkout with the HEAD tag. Let me know if it could be improved.

tr’s picture

Patch looks fine - I don't know if it works to fix the problem (I don't currently have a PayPal setup to test against). Perhaps @essbee can check, since he was the one having the problem in the first place?

longwave’s picture

Status: Active » Fixed

Tested and committed. Meriial, thanks for submitting the patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

n8o’s picture

Version: 7.x-3.0-beta1 » 7.x-3.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new534 bytes

This problem also affects the Express Checkout payment method. I have attached a patch for it, as well against 7.x-3.x-dev . Hope it works out!

longwave’s picture

Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.