When block style is active - contextual links disappeared. With "no style" - they are in place.

Suggest add to
panels/plugins/styles/block.inc:51
this junk

  if ($key != 'system_main' && $key != 'system_help') {
    $build['#contextual_links']['block'] = array('admin/structure/block/manage', array($block->module, $block->delta));
  }

works for me!

CommentFileSizeAuthor
#4 panels-adding-contextual-links-100644-4.patch529 bytescolincalnan
#3 1047392_panel-block-contextual-links.patch582 bytesmatulis

Comments

Kat_Sweden’s picture

Kat_Sweden commented

Thanks, this worked for me too

Letharion’s picture

Letharion commented
Assigned: Unassigned » Letharion
Status: Active » Needs work

Needs to be made into a patch.

matulis’s picture

matulis commented
Version: 7.x-3.0-alpha2 » 7.x-3.2
StatusFileSize
new 1047392_panel-block-contextual-links.patch582 bytes

This is still an issue with 7.x-3.2

colincalnan’s picture

colincalnan commented
Version: 7.x-3.2 » 7.x-3.x-dev
Assigned: Letharion » colincalnan
Category: bug » feature
Status: Needs work » Patch (to be ported)
StatusFileSize
new panels-adding-contextual-links-100644-4.patch529 bytes

That patch did not work for the 3.x-dev branch or 3.2.

This should do the job for both.

Can this please go into the next release!

merlinofchaos’s picture

merlinofchaos commented
Status: Patch (to be ported) » Needs review

patch (to be ported) means there is a patch for another version of the module (usually Drupal 7 -> Drupal 6) that needs to be backported.

You want 'needs review'.

merlinofchaos’s picture

merlinofchaos commented

patch (to be ported) means there is a patch for another version of the module (usually Drupal 7 -> Drupal 6) that needs to be backported.

You want 'needs review'.

And in a quick review of that patch, I think it will add broken links for any pane that is not actually a Drupal block. So as it is, it can't be committed.

Also note that Panes come with their own sets of contextual links, which will include those provided by block.module. So we should be using those. See the code in template_preprocess_panels_pane() which handles htis. Presumably that code could be generalized and re-used so that both pane styles can utilze it.

wickwood’s picture

wickwood commented
Issue summary: View changes

While looking for a solution to this old issue I found https://drupal.org/node/1925460 and marked it as a duplicate of this one.

wickwood’s picture

wickwood commented
Status: Needs review » Needs work

MerlinOfChaos is (of course) correct, the patch in #4 does break links for any pane that is not actually a Drupal block by replacing all contextual links for any panel that styled as a system block with "Configure Block".

For example, a Menu panel styled as a system block without this patch will have the contextual links of "Lists Links" and "Edit Menu", but with this patch the only contextual link for that same panel is "Configure Block".

A Custom Block pane without this patch doesn't have any contextual links at all, but with the patch you have the contextual link of "Configure Block".

It should also be noted that Views Panes don't have contextual links either, but that issue can be solved without breaking any other contextual links by patching Ctools as discussed on https://drupal.org/node/1669756 but this still leaves the Custom Block panes without any contextual links.

What I find hard to believe is that this issue is so old and no one else has had problem with this or figured out a solution to it yet. If there is a solution, I have not found it yet and believe me I've searched and I searched. I'm beginning to think that there is something within Panels itself that will prevent this for Custom Blocks styled as System Blocks, but I haven't found anything saying that either.

If find a solution (or create one if I can), I will post back of course, but if anyone actually knows of a solution to this, please point me in that direction!

Thanks in advance!
Steve

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.