Closed (fixed)
Project:
simplehtmldom API
Version:
7.x-1.11
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Feb 2011 at 20:20 UTC
Updated:
16 Feb 2014 at 19:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
xurizaemonThere are several advantages to sites/*/libraries instead of using this module, whether or not you use the Libraries API or simply include the files from Libraries.
* removes the dependency on this module,
* avoids loading the simple_html_dom library on each request,
* and also seems more in keeping with 3rd party libraries in Drupal CVS.
* means you don't need to maintain a patched version to work around issues in this module, eg #922874: Notice: Undefined variable: function_name in include_once() (line 7 of ...simplehtmldom/simplehtmldom.module).
Comment #2
skilip commentedOne big plus for this one. There's absolutely no reason to load the Simple HTML library on each page load, as it does now. When using the Library API you'll make it possible to load the Smple HTML library only when needed using drupal_add_library().
Comment #3
skilip commentedComment #4
alexkb commentedSkilip's solution is much better, but for anyone else out there trying to implement this, make sure the simple html dom library is extracted into sites/all/libraries/simplehtmldom. The folder name needs to be the same as the key in $libraries. Also, the latest 1.5 version of simple html dom, is v1.5 and this is printed differently in the php file, so the regex needs to be changed. Here's what worked for me:
Comment #5
Konstantin Komelin commentedProvided patch includes several changes, such as:
Please review.
P.S. Please use
git apply --indexto apply the patch.Comment #6
Konstantin Komelin commentedIf you don't have time please give me necessary permissions and I'll do everything myself.
Comment #7
Konstantin Komelin commentedCommited patch #5 04d9593 with minor text modifications.
New release 7.x-2.x created https://drupal.org/node/2187329
Comment #8
Konstantin Komelin commented