EveryScape integration module [#1048112]

The following module provides Drupal integration with the EveryScape guided virtual tour service (http://www.everyscape.com).

This is a very simple module, consisting of an administrative settings form and one or more blocks. The administrative settings form allows the site admin to choose how many EveryScape blocks will be available to Drupal, as well as the default size of these blocks.

The individual blocks can be programmed with an EveryScape panorama ID. Their height and width can also be specified on a per-block basis.

This module was designed for Drupal 7.

This module has been checked by the "coder" module, and is fully compliant, minus the CVS $Id line. No example site is currently available, as this module was built for a staging site that will be launched in about a month.

Please see attached.

Comment	File	Size	Author
	everyscape.tar_.gz	1.85 KB	noahlively

Comments

Comment #1

zzolo commented 28 February 2011 at 06:25

Status:

Active

» Postponed

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

Comment #2

noahlively commented 2 March 2011 at 01:05

Project:	Drupal.org CVS applications	» Drupal.org security advisory coverage applications
Status:	Postponed	» Needs review

Ported to Git. Here is a link to my sandbox project.
http://drupal.org/sandbox/noahlively/1078032

Comment #3

lorinpda commented 18 March 2011 at 14:37

Hi,
I installed the latest snapshot from your sandbox on a local Drupal 7.0 installation. A few minor issues/suggestions:

I would add a README.txt and a INSTALL.txt to detail usage and installation.
I would consider implementing hook_help() along the same lines. Give users some instructions.
I ran the source through Coder and it reported some minor formatting issues (3.g. @file missing).
Is there a reason why you chose to split all the functions in to separate file listings. Plus is there a reason why you don't simply load files such as admin.inc through your .info?
Not a requirement, just a suggestion :) Is there any demo Panorama ID you can provide. Or at least give folks a 1-2-3 on how to obtain a Panorama ID, cost, etc. ? A nice to have, but not a requirement.
Other than that, the only real issue is just the minor formatting issues raised by Coder. If you take care of those, add some instructions/help, I would say this is ready t be approved.

Hope that helps.
Lorin

Comment #4

meba commented 16 April 2011 at 07:21

Status:

Needs review

» Needs work

I am unsure about the file separation. It's definitely a very interesting idea but not sure if it aligns with coding standards...Setting to needs work because after reading the code, I had trouble understanding it in context since I had to switch files all the time, especially with such a small module

drupal_add_js("http://api.everyscape.com/api/api.js?modules=Script&v=1.x&key=AQAAAAA...AAAADr1twxAAAAAA&modules=Script", 'external');

Are you sure you didn't expose your key here? Shouldn't your users have different key?

Comment #5

bogdog400 commented 21 April 2011 at 23:06

This is a nice block. I like it.

My suggestions:

* Let us input our own key without editing the file.
* Let us use a field on the node to choose the id for the panorama. So different nodes can get different panorama.

Thanks.