warning: Invalid argument supplied for foreach() in modules/viewfield on line 279.

Hi
I had the same problem today, it appears first when I was adding new books with root-nodes of secondary links (the 2 content types have the viewfield embedded with CCK, first added to page and then duplicated to bookpage). Not sure, but it may be related...
The warning message disapear when I click once to go somewhere else in the website.

Cheers

Can you provide the PHP warning message (including file and line info) when running on 1.x-dev, please?

subscribing

In the development version 6.x-1.x, the viewfield.module code around line 277 has been rewritten at this point. Please try this version and reopen if the problem recurs.

I have same issue if my view only have default display.
I make a patch to resolve this (i just make git pull so the patch has been done on the last 6.x-1.x commit).

@GoZ Thanks for your patch, but I cannot duplicate this problem with viewfield-6.x-1.x-dev and views-6.x-2.12. I don't understand how any view with a single default display can have isset($view->display) == FALSE. Please provide specific steps to reproduce the problem.

EDIT: Corrected $view->default to $view->display.

Problem is not isset($view->default) == FALSE but isset($view->display) == FALSE
To reproduce this, make a view with only default display. Don't create displays.
During node creation, in your cck field, choose this view and submit your form. Message appear.
Error message only appear at submission.

The view correctly displays in the node, no error during node display.

@GoZ I still cannot reproduce your problem.

This is what I tried.

Created a view 'test_view'. If I don't customize anything, attempting to save the view produces the message 'Display "Defaults" uses fields but there are none defined for it or all are excluded.' so I added single field, Node Title. At this point the test_view can be saved and run; it produces a list of all node titles linked to a node. Then I added a new viewfield to the Story content type. When adding it, I examined the value of $view->display in _viewfield_potential_references() using a debugger. Every view, including test_view, had a valid display property, and I received no warning. Then I updated the values in a Story node that existed before the viewfield was created by selecting 'test_view | Defaults' and no argument. Still no warning. Viewing the node shows that the viewfield is running test_view correctly.

@keithm : I found why this error display. In _viewfield_potential_references(), you make foreach on $field['allowed_views'] but if in your cck viewfield (in content type cck settings) you select a view that you delete later, this view always be stored in cck viewfield (until you submit cck viewfield content type again).
So you make foreach on allowed_views stored and make views_get_view of a view that doesn't exist anymore.

To reproduce :
Make test view.
In your content type cck settings, add this view to your cck viewfield.
Delete this view
Create content of your content type. Error message display.
Go to your content type cck settings, submit your cck viewfield settings (view deleted has disapeard from checkbox)
No more error message.

So you should test !empty($view) before foreach ($view->display

@GoZ Now this makes sense to me. Thanks for investigating. Patch attached.

Looks ready for me. For D7, we should create a separate issue and discuss proper error handling (throwing an error message, watchdog log message, field value validation, implementing views hooks to react on deletion of views, etc)

Commited in http://drupalcode.org/project/viewfield.git/commit/879ca47, http://drupalcode.org/project/viewfield.git/commit/59c79f1, and http://drupalcode.org/project/viewfield.git/commit/450a2cc (D7, for now). Opened new D7 issue #1168386: Handle deleted views in allowed_views list.