The Droptor module seems to incorporate a small BSD-licensed library:

http://drupalcode.org/viewvc/drupal/contributions/modules/droptor/dropto...

This is probably fine in terms of license since BSD is GPL compatible, but it would be helpful to clarify within the code that this has been re-licensed as GPL.

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Seeing as the code is readily and easily downloadable (http://www.dominicsayers.com/isemail/) it would stand that this would be a violation of our external library policy.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Possible license issue in Droptor module » Remove/clarify the droptor_is_email function due to license issues
Project: Drupal.org site moderators » Droptor
Version: » 6.x-2.71
Component: Licensing » Code
Category: support » task

I don't even see a call to that function form within the current droptor code. Maybe it's just cruft and can be removed no problem.

Either way, the place for this is the module issue queue first and then webmasters if it needs to be moved there for some reason.

jemond’s picture

jemond commented

Hi Team,

Thanks for the update. I will take a look at this today and update you later this afternoon.

jpe

jemond’s picture

jemond commented
Assigned: Unassigned » jemond
jemond’s picture

jemond commented

This can be removed. I will have commits done by later today.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Remove/clarify the droptor_is_email function due to license issues » Possible license issue in Droptor module
Project: Droptor » Drupal.org site moderators
Version: 6.x-2.71 »
Component: Code » Licensing
Assigned: jemond » Unassigned
Category: task » support

It also does not look like it was modified at all besides to comply with Drupal coding standards.

jemond’s picture

jemond commented
Title: Possible license issue in Droptor module » Remove/clarify the droptor_is_email function due to license issues
Project: Drupal.org site moderators » Droptor
Version: » 6.x-2.71
Component: Licensing » Code
Assigned: Unassigned » jemond
Category: support » task
Status: Active » Fixed

Hi Team,

Thanks again for reporting this.

This is fixed in both 6 and 7. I have a release coming out today, so it will be included in that.

jpe

jemond’s picture

jemond commented
Status: Fixed » Closed (fixed)

Hi Team,

This is included in the 2.8 just released.

jpe

blackdog’s picture

blackdog commented
Status: Closed (fixed) » Needs work

Not removed from the 7.x branch.

blackdog’s picture

blackdog commented
Version: 6.x-2.71 » 7.x-2.71
jemond’s picture

jemond commented

Whoops, thanks! I will get it removed.

jemond’s picture

jemond commented
Status: Needs work » Closed (fixed)

I am reading the module for a 3.0 release, and confirmed it's gone there.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

It's still in http://drupalcode.org/project/droptor.git/blob/refs/heads/master:/dropto... - would be great to remove it from that branch as well.

jemond’s picture

jemond commented

Done.